gtk4.git
3 years agoRelease to unstable
Simon McVittie [Tue, 6 Dec 2022 11:52:39 +0000 (11:52 +0000)]
Release to unstable

3 years agoUpdate changelog
Simon McVittie [Tue, 6 Dec 2022 11:52:24 +0000 (11:52 +0000)]
Update changelog

3 years agoRevert "Work around Mesa regresion #1025312 by forcing software rendering"
Simon McVittie [Tue, 6 Dec 2022 11:50:19 +0000 (11:50 +0000)]
Revert "Work around Mesa regresion #1025312 by forcing software rendering"

This reverts commit 21fbef6d66586999e9a57d1c57694a4b8771f1c7.

3 years agoUpdate changelog
Simon McVittie [Tue, 6 Dec 2022 11:50:07 +0000 (11:50 +0000)]
Update changelog

3 years agoUpdate from upstream gtk-4-8 branch
Simon McVittie [Tue, 6 Dec 2022 11:49:47 +0000 (11:49 +0000)]
Update from upstream gtk-4-8 branch

- Fix visual artifacts on X11
- Update translations

3 years agod/patches: Sort Debian-specific patches to the end of the series
Simon McVittie [Tue, 6 Dec 2022 11:45:14 +0000 (11:45 +0000)]
d/patches: Sort Debian-specific patches to the end of the series

3 years agoAdd patch to make the node editor reproducible
Simon McVittie [Tue, 6 Dec 2022 11:43:45 +0000 (11:43 +0000)]
Add patch to make the node editor reproducible

3 years agoUpdate changelog
Simon McVittie [Mon, 5 Dec 2022 11:21:09 +0000 (11:21 +0000)]
Update changelog

3 years agoDon't try to install man pages under nodoc build-profile
Simon McVittie [Fri, 2 Dec 2022 22:51:09 +0000 (22:51 +0000)]
Don't try to install man pages under nodoc build-profile

3 years agoDrop unused docbook and xsltproc build-dependencies
Simon McVittie [Fri, 2 Dec 2022 22:46:33 +0000 (22:46 +0000)]
Drop unused docbook and xsltproc build-dependencies

The man pages now use python3-docutils instead.

3 years agoUpdate changelog
Simon McVittie [Fri, 2 Dec 2022 15:24:11 +0000 (15:24 +0000)]
Update changelog

3 years agoWork around Mesa regresion #1025312 by forcing software rendering
Simon McVittie [Fri, 2 Dec 2022 15:23:01 +0000 (15:23 +0000)]
Work around Mesa regresion #1025312 by forcing software rendering

We expect only software rendering to be available in typical buildd or
autopkgtest environments anyway, so this is no real loss.

3 years agod/rules: Remove redundant --libdir override
Simon McVittie [Fri, 2 Dec 2022 10:32:40 +0000 (10:32 +0000)]
d/rules: Remove redundant --libdir override

3 years agoAdd patches to improve handling of flaky/failing tests
Simon McVittie [Wed, 23 Nov 2022 21:34:14 +0000 (21:34 +0000)]
Add patches to improve handling of flaky/failing tests

3 years agoRelease to unstable
Simon McVittie [Fri, 18 Nov 2022 22:12:30 +0000 (22:12 +0000)]
Release to unstable

3 years agoUpdate changelog
Simon McVittie [Fri, 18 Nov 2022 22:12:03 +0000 (22:12 +0000)]
Update changelog

3 years agoUpdate to upstream commit 4.8.2-21-g753c6f2435
Simon McVittie [Fri, 18 Nov 2022 22:11:23 +0000 (22:11 +0000)]
Update to upstream commit 4.8.2-21-g753c6f2435

- Trigger on-screen keyboard more reliably
- Don't dismiss popups unnecessarily

3 years agoSkip border-image-excess-size reftest on big-endian machines
Simon McVittie [Fri, 18 Nov 2022 21:38:04 +0000 (21:38 +0000)]
Skip border-image-excess-size reftest on big-endian machines

Mitigates: #1024391

3 years agoRelease to unstable
Simon McVittie [Fri, 18 Nov 2022 09:56:46 +0000 (09:56 +0000)]
Release to unstable

3 years agod/patches: Update to upstream gtk-4-8 branch commit 4.8.2-18-g205783d9b0
Simon McVittie [Fri, 18 Nov 2022 09:48:10 +0000 (09:48 +0000)]
d/patches: Update to upstream gtk-4-8 branch commit 4.8.2-18-g205783d9b0

- Fix handling of AltGr when multiple keyboard layouts use it
- Fix handling of back/forward mouse buttons
- Fix a focus handling regression
- Fix a regression that caused a very narrow combo box drop-down in
  GNOME Settings since 4.8
- Fix a regression with copying under Phosh since 4.8
- Don't confine resized windows to the geometry of the first monitor
- Translation updates

3 years agoBuild-/test-depend on dbus-daemon instead of dbus
Simon McVittie [Fri, 18 Nov 2022 09:32:36 +0000 (09:32 +0000)]
Build-/test-depend on dbus-daemon instead of dbus

We only need dbus-run-session here, not the system bus.

3 years agod/watch, d/gbp.conf: Only watch for 4.8.x versions
Simon McVittie [Fri, 18 Nov 2022 09:29:01 +0000 (09:29 +0000)]
d/watch, d/gbp.conf: Only watch for 4.8.x versions

Development release 4.9.1 has already happened, but is unlikely to reach
a stable branch before the Debian 12 freeze.

3 years agoRelease to unstable
Simon McVittie [Sat, 29 Oct 2022 10:55:55 +0000 (11:55 +0100)]
Release to unstable

3 years agoUpdate changelog
Simon McVittie [Sat, 29 Oct 2022 10:54:42 +0000 (11:54 +0100)]
Update changelog

3 years agod/patches: Remove patches that were applied upstream
Simon McVittie [Sat, 29 Oct 2022 10:54:05 +0000 (11:54 +0100)]
d/patches: Remove patches that were applied upstream

3 years agod/control.in: Update Meson build-dependency
Simon McVittie [Sat, 29 Oct 2022 10:53:09 +0000 (11:53 +0100)]
d/control.in: Update Meson build-dependency

3 years agoNew upstream release
Simon McVittie [Sat, 29 Oct 2022 10:34:39 +0000 (11:34 +0100)]
New upstream release

3 years agoUpdate upstream source from tag 'upstream/4.8.2+ds'
Simon McVittie [Sat, 29 Oct 2022 10:34:38 +0000 (11:34 +0100)]
Update upstream source from tag 'upstream/4.8.2+ds'

Update to upstream version '4.8.2+ds'
with Debian dir 9a1f6b5e92abec8dce98910345e626ba12661625

3 years agoNew upstream version 4.8.2+ds
Simon McVittie [Sat, 29 Oct 2022 10:34:11 +0000 (11:34 +0100)]
New upstream version 4.8.2+ds

3 years agod/copyright: Stop excluding libwayland, wayland-protocols
Simon McVittie [Sat, 29 Oct 2022 10:31:35 +0000 (11:31 +0100)]
d/copyright: Stop excluding libwayland, wayland-protocols

These are no longer in the upstream tarball release.

3 years ago4.8.2
Matthias Clasen [Mon, 24 Oct 2022 17:46:56 +0000 (13:46 -0400)]
4.8.2

3 years agoUpdate Serbian translation
Мирослав Николић [Sun, 23 Oct 2022 09:21:30 +0000 (09:21 +0000)]
Update Serbian translation

3 years agoMerge branch 'wip/antoniof/backport-list-focus' into 'gtk-4-8'
Matthias Clasen [Fri, 21 Oct 2022 17:34:35 +0000 (17:34 +0000)]
Merge branch 'wip/antoniof/backport-list-focus' into 'gtk-4-8'

Backport MR !5023 to 4.8

See merge request GNOME/gtk!5157

3 years agoMerge branch 'fix-focus-4-8' into 'gtk-4-8'
Matthias Clasen [Fri, 21 Oct 2022 17:33:13 +0000 (17:33 +0000)]
Merge branch 'fix-focus-4-8' into 'gtk-4-8'

[4.8] window: Fix focus updates

See merge request GNOME/gtk!5133

3 years agoeditablelabel: Defer changes on focus-out
Matthias Clasen [Tue, 18 Oct 2022 18:23:22 +0000 (14:23 -0400)]
editablelabel: Defer changes on focus-out

We can get spurious focus-out/-in pairs when
the editable label is in a popover that gets
a Wayland keyboard enter event as a result of
clicking the editable label.

A timeout isn't a great solution, but nothing
better is available right now.

Fixes: #4864
3 years agowindow: Keep a reference to move_focus_widget
Matthias Clasen [Tue, 18 Oct 2022 18:21:51 +0000 (14:21 -0400)]
window: Keep a reference to move_focus_widget

If we don't take a reference, it can happen that
the pointer is no longer valid by the time we
dereference it in after_paint.

3 years agocolumnview: Forward all focus to child
António Fernandes [Sat, 10 Sep 2022 22:43:57 +0000 (22:43 +0000)]
columnview: Forward all focus to child

For the same reasoning as the preceding commit.

Also don't make GtkColumnView focusable. Its internal list view
is already focusable, which is enough to take care of the empty
view case.

(cherry picked from commit 9cb8d21cb59d2aeedcc877c4121e9032b23a573d)

3 years agolistbase: Grab focus on items instead of container
António Fernandes [Thu, 15 Sep 2022 00:52:22 +0000 (01:52 +0100)]
listbase: Grab focus on items instead of container

The container view itself being focusable makes keyboard navigation
slower by adding a useless focus step.

It also means if an item gets removed, the focus jumps back to the view,
instead of jumping to the next item, as seen in nautilus bug report:
https://gitlab.gnome.org/GNOME/nautilus/-/issues/2489

Instead of making the GtkListBase container itself focusable, override
the .grab_focus() vfunc. This way, calling gtk_widget_grab_focus() on
the view container keeps working sucessfully, but focuses the focus
item directly instead.

This is particularly useful to have because applicaiton authors do
not have direct acess to this class's children, so they can't call
gtk_widget_grab_focus() on them directly.

(cherry picked from commit 4fc429892086e8bc1c9be94d5184e7eeff518f9c)

3 years agowindow: Don't focus invisible widgets
Matthias Clasen [Mon, 17 Oct 2022 19:10:51 +0000 (15:10 -0400)]
window: Don't focus invisible widgets

Only clear a queued move_focus if the widget
we are focusing is actually visible.

This was happening in some cases when popovers
are dismissed by clicking outside, and it was
causing us to miss proper focus updates that
were already queued.

3 years agowindow: Fix focus updates
Matthias Clasen [Mon, 17 Oct 2022 16:29:44 +0000 (12:29 -0400)]
window: Fix focus updates

This partially undoes changes from 3dbf5038fab8eb0.

That commit did two things:
1) Move the focus update to after-paint time
2) Change from grabbing focus to the visible parent
   to  calling move_focus (TAB)

The second part did have the unintended consequence
of moving focus laterally.

Fixes: #4903
3 years agoUpdate Indonesian translation
Kukuh Syafaat [Tue, 18 Oct 2022 02:47:51 +0000 (02:47 +0000)]
Update Indonesian translation

3 years agoMerge branch 'backport-mr-4986-to-gtk-4-8' into 'gtk-4-8'
Luca Bacci [Mon, 17 Oct 2022 20:40:44 +0000 (20:40 +0000)]
Merge branch 'backport-mr-4986-to-gtk-4-8' into 'gtk-4-8'

Use native Windows API for converting keystrokes to characters

See merge request GNOME/gtk!5130

3 years agoUse native Windows API for converting keystrokes to characters
Philip Zander [Wed, 24 Aug 2022 11:21:10 +0000 (13:21 +0200)]
Use native Windows API for converting keystrokes to characters

3 years agoUpdate Russian translation
Aleksandr Melman [Sun, 9 Oct 2022 13:24:27 +0000 (13:24 +0000)]
Update Russian translation

3 years agoUpdate Georgian translation
Zurab Kargareteli [Thu, 6 Oct 2022 21:21:24 +0000 (21:21 +0000)]
Update Georgian translation

3 years agoUpdate German translation
Jürgen Benvenuti [Thu, 6 Oct 2022 20:48:31 +0000 (20:48 +0000)]
Update German translation

3 years agoMerge branch 'wip/headless-infinite-bounds-4-8' into 'gtk-4-8'
Matthias Clasen [Thu, 6 Oct 2022 10:42:51 +0000 (10:42 +0000)]
Merge branch 'wip/headless-infinite-bounds-4-8' into 'gtk-4-8'

[4.8] Fix shrinking windows on suspend/resume

See merge request GNOME/gtk!5090

3 years agotoplevel-size: Report zero bounds as infinite
Jonas Ådahl [Fri, 30 Sep 2022 07:26:55 +0000 (09:26 +0200)]
toplevel-size: Report zero bounds as infinite

Empty/zero bounds are sent by the Wayland compositor if there are no
valid bounds to report, e.g. if there are no connected monitors. Report
this to GTK, which uses this to clamp calculated sizes, as INT_MAX, so
that clamping isn't done until there are actual valid bounds to clamp
to.

This fixes clients sometimes shrinking to their minimum size during
hotplugs or after having suspended the session.

(cherry picked from commit b3a3a6ceb19cdc00da0d201531cff93a059a86d3)

3 years agosurface/wayland: Handle no current monitor when calculating bounds
Jonas Ådahl [Fri, 30 Sep 2022 07:30:30 +0000 (09:30 +0200)]
surface/wayland: Handle no current monitor when calculating bounds

We shouldn't assume there is always a monitor to derive bounds from.
If there is no monitor, pass empty bounds, as this matches what
xdg_toplevel.configure_bounds do in this case.

(cherry picked from commit 148c1336745a043a9660da6c4734ed905c628130)

3 years agoUpdate Bulgarian translation
Alexander Shopov [Tue, 4 Oct 2022 18:07:20 +0000 (18:07 +0000)]
Update Bulgarian translation

3 years agoUpdate Catalan translation
Jordi Mas [Mon, 3 Oct 2022 18:07:15 +0000 (20:07 +0200)]
Update Catalan translation

3 years agoUpdate Friulian translation
Fabio Tomat [Mon, 3 Oct 2022 08:35:52 +0000 (08:35 +0000)]
Update Friulian translation

3 years agoUpdate Croatian translation
Goran Vidović [Sun, 2 Oct 2022 14:03:13 +0000 (14:03 +0000)]
Update Croatian translation

3 years agoUpdate Turkish translation
Emin Tufan Çetin [Sat, 1 Oct 2022 14:56:16 +0000 (14:56 +0000)]
Update Turkish translation

3 years agoPost-release version bump
Matthias Clasen [Wed, 28 Sep 2022 17:17:46 +0000 (13:17 -0400)]
Post-release version bump

This is an experiment to see if I can keep up with
doing post-release version bumps, so git snapshots
will always have a different version from released
tarballs.

3 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Wed, 28 Sep 2022 17:02:09 +0000 (17:02 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

Add more names to sources

See merge request GNOME/gtk!5064

3 years agoAdd more names to sources
Matthias Clasen [Wed, 28 Sep 2022 16:36:22 +0000 (12:36 -0400)]
Add more names to sources

This helps with identifying things in sysprof logs,
and while debugging.

3 years agoMerge branch 'post-install' into 'main'
Matthias Clasen [Wed, 28 Sep 2022 16:21:49 +0000 (16:21 +0000)]
Merge branch 'post-install' into 'main'

meson: Remove post-install script

See merge request GNOME/gtk!5063

3 years agomeson: Remove post-install script
Xavier Claessens [Wed, 28 Sep 2022 15:24:51 +0000 (11:24 -0400)]
meson: Remove post-install script

GTK depends on Meson >= 0.60 so it was never used.

3 years agoMerge branch 'wip/carlosg/shuffle-reset-take2' into 'main'
Matthias Clasen [Wed, 28 Sep 2022 01:39:49 +0000 (01:39 +0000)]
Merge branch 'wip/carlosg/shuffle-reset-take2' into 'main'

gtkimcontextwayland: Shuffle full resets after IM changes

Closes #5200

See merge request GNOME/gtk!5050

3 years agoMerge branch 'wroy-main-patch-32519' into 'main'
Matthias Clasen [Wed, 28 Sep 2022 01:39:15 +0000 (01:39 +0000)]
Merge branch 'wroy-main-patch-32519' into 'main'

Fix #5211: Preprocessor conformance with MSVC

Closes #5211

See merge request GNOME/gtk!5058

3 years agoMerge branch 'broadway-device-query-state-fix' into 'main'
Matthias Clasen [Wed, 28 Sep 2022 01:38:45 +0000 (01:38 +0000)]
Merge branch 'broadway-device-query-state-fix' into 'main'

GTK4 gdk/broadway: correct gdk_broadway_device_query_state() to return pointer coordinates relative to the upper left corner of surface

See merge request GNOME/gtk!5053

3 years agoMerge branch 'fix-scale-crashes' into 'main'
Matthias Clasen [Wed, 28 Sep 2022 01:22:49 +0000 (01:22 +0000)]
Merge branch 'fix-scale-crashes' into 'main'

scale: Fix a typo

See merge request GNOME/gtk!5061

3 years agoscale: Fix a typo
Matthias Clasen [Wed, 28 Sep 2022 01:03:56 +0000 (21:03 -0400)]
scale: Fix a typo

We want to update the label size request when
the adjustment changes, not when anything else
changes.

This may be the reason for crash reports like
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=1e5cc1318358d5db298e5d6c2ec47361922cce74

3 years agoUpdated Lithuanian translation
Aurimas Černius [Tue, 27 Sep 2022 19:40:49 +0000 (22:40 +0300)]
Updated Lithuanian translation

3 years agoUpdate Portuguese translation
Hugo Carvalho [Tue, 27 Sep 2022 19:39:53 +0000 (19:39 +0000)]
Update Portuguese translation

3 years agoUpdate Brazilian Portuguese translation
Rafael Fontenelle [Tue, 27 Sep 2022 13:10:05 +0000 (13:10 +0000)]
Update Brazilian Portuguese translation

3 years agoApply 1 suggestion(s) to 1 file(s)
Matthias Clasen [Tue, 27 Sep 2022 11:31:55 +0000 (11:31 +0000)]
Apply 1 suggestion(s) to 1 file(s)

3 years agoUpdate Slovenian translation
Martin [Tue, 27 Sep 2022 08:03:24 +0000 (08:03 +0000)]
Update Slovenian translation

3 years agoUpdate Galician translation
Fran Dieguez [Tue, 27 Sep 2022 06:22:18 +0000 (06:22 +0000)]
Update Galician translation

3 years agoMerge branch 'wip/otte/for-main' into 'main'
Benjamin Otte [Tue, 27 Sep 2022 02:07:21 +0000 (02:07 +0000)]
Merge branch 'wip/otte/for-main' into 'main'

drop target: Warn about broken signal handler returns

See merge request GNOME/gtk!5060

3 years agodrop target: Warn about broken signal handler returns
Benjamin Otte [Tue, 27 Sep 2022 01:44:41 +0000 (03:44 +0200)]
drop target: Warn about broken signal handler returns

Signal handlers ust return their preferred action and that one must be
unique.

Shout at them if they don't do that, before gdk_drop_status() does
tesame thing.

Related: gnome-build-meta#554
Related: gnome-builder#1799

3 years agoMerge branch 'left-right-typo' into 'main'
Emmanuele Bassi [Mon, 26 Sep 2022 22:23:29 +0000 (22:23 +0000)]
Merge branch 'left-right-typo' into 'main'

Fix GtkSettings docs typo

See merge request GNOME/gtk!5059

3 years agoFix GtkSettings docs typo
Mitchell Hentges [Mon, 26 Sep 2022 22:00:30 +0000 (00:00 +0200)]
Fix GtkSettings docs typo

"left of right" should be "left or right".
There's a small (subjective?) English nit in there as well: I believe
that buttons are placed (for example) "on the right" rather than "at the
right".

3 years agoFix preprocessor conformance with MSVC
William Roy [Mon, 26 Sep 2022 19:52:57 +0000 (19:52 +0000)]
Fix preprocessor conformance with MSVC

3 years agoUpdate Croatian translation
Goran Vidović [Mon, 26 Sep 2022 19:30:45 +0000 (19:30 +0000)]
Update Croatian translation

3 years agoUpdate Swedish translation
Anders Jonsson [Mon, 26 Sep 2022 18:28:19 +0000 (18:28 +0000)]
Update Swedish translation

3 years agoMerge branch 'kjellahl/gtkprintbackendlpr' into 'main'
Matthias Clasen [Mon, 26 Sep 2022 18:22:21 +0000 (18:22 +0000)]
Merge branch 'kjellahl/gtkprintbackendlpr' into 'main'

gtkprintbackendlpr.c: Add #include "gtkprivate.h"

See merge request GNOME/gtk!5057

3 years agogtkprintbackendlpr.c: Add #include "gtkprivate.h"
Kjell Ahlstedt [Mon, 26 Sep 2022 16:38:06 +0000 (18:38 +0200)]
gtkprintbackendlpr.c: Add #include "gtkprivate.h"

Necessary after GTK_NOTE was replaced by GTK_DEBUG.
GTK_DEBUG is defined in gtk/gtkprivate.h. GTK_NOTE was defined
in gtk/gtkdebug.h.

3 years agoUpdate Polish translation
Piotr Drąg [Mon, 26 Sep 2022 16:01:02 +0000 (18:01 +0200)]
Update Polish translation

3 years agoUpdate Ukrainian translation
Yuri Chornoivan [Mon, 26 Sep 2022 14:54:56 +0000 (14:54 +0000)]
Update Ukrainian translation

3 years agoMerge branch 'fix_4577' into 'main'
Matthias Clasen [Mon, 26 Sep 2022 14:41:29 +0000 (14:41 +0000)]
Merge branch 'fix_4577' into 'main'

Make the presentation of the stack sidebar listbox nicer for A11Y

Closes #4577

See merge request GNOME/gtk!4661

3 years agoMerge branch 'gdk-win32-fix-subclassing-gdk-win32-clipdrop' into 'main'
Luca Bacci [Mon, 26 Sep 2022 12:59:17 +0000 (12:59 +0000)]
Merge branch 'gdk-win32-fix-subclassing-gdk-win32-clipdrop' into 'main'

GdkWin32: Fix subclassing for GdkWin32Clipdrop

Closes #5207

See merge request GNOME/gtk!5055

3 years agoGdkWin32: Fix subclassing for GdkWin32Clipdrop
Luca Bacci [Mon, 26 Sep 2022 12:34:24 +0000 (14:34 +0200)]
GdkWin32: Fix subclassing for GdkWin32Clipdrop

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/5207

3 years agoMerge branch 'bump-meson-req' into 'main'
Matthias Clasen [Sun, 25 Sep 2022 17:24:53 +0000 (17:24 +0000)]
Merge branch 'bump-meson-req' into 'main'

Bump the meson requirement

See merge request GNOME/gtk!5051

3 years agoUpdate POTFILES.in
Piotr Drąg [Sun, 25 Sep 2022 12:10:28 +0000 (14:10 +0200)]
Update POTFILES.in

3 years agogtk: Use gnome.mkenums_simple
Matthias Clasen [Sun, 25 Sep 2022 01:22:26 +0000 (21:22 -0400)]
gtk: Use gnome.mkenums_simple

This lets us avoid template files, and works just as well.

3 years agogdk: Use gnome.mkenums_simple
Matthias Clasen [Sun, 25 Sep 2022 00:41:09 +0000 (20:41 -0400)]
gdk: Use gnome.mkenums_simple

This lets us avoid template files, and works just as well.

3 years agoBump the meson requirement
Matthias Clasen [Sun, 25 Sep 2022 00:07:03 +0000 (20:07 -0400)]
Bump the meson requirement

GLib requires meson 0.60 nowadays, and it does not
make much sense for us to support an older meson.

3 years agoMerge branch 'header-cleanup' into 'main'
Matthias Clasen [Sat, 24 Sep 2022 14:23:39 +0000 (14:23 +0000)]
Merge branch 'header-cleanup' into 'main'

Header cleanup

See merge request GNOME/gtk!5049

3 years agogdk: Rename gdkpixbuf-drawable.c
Matthias Clasen [Sat, 24 Sep 2022 13:23:18 +0000 (09:23 -0400)]
gdk: Rename gdkpixbuf-drawable.c

There is nothing particularly specific to drawables
in there (and we don't have that concept anymore),
so just name the source file to match the header.
Easier for everybody.

3 years agogdk: Tweaks to keyname handling
Matthias Clasen [Sat, 24 Sep 2022 13:20:12 +0000 (09:20 -0400)]
gdk: Tweaks to keyname handling

Rename the private header to follow our naming
conventions, and drop the extra gdkkeys.c file.

3 years agoDrop gtkintl.h
Matthias Clasen [Sat, 24 Sep 2022 13:07:56 +0000 (09:07 -0400)]
Drop gtkintl.h

Include gtkprivate.h for I_() and glib-i18n.h for
gettext macros.

3 years agogtkimcontextwayland: Shuffle full resets after IM changes
Carlos Garnacho [Sat, 24 Sep 2022 09:45:18 +0000 (11:45 +0200)]
gtkimcontextwayland: Shuffle full resets after IM changes

Doing reset() on the text widgets after commit and delete_surrounding
is still too eager for some IMs (e.g. those that expect being able
to commit text while keeping a preedit buffer shown).

However, reset() is more of a "synchronize state" action on Wayland,
and it is still desirable to do that after changes that do come from
the IM (e.g. requesting the new surrounding text and cursor/anchor
positions). Notably here, the text_input protocol may still come up
with a preedit string after this state synchronization happens.

Shuffle the code so that the text widgets do not reset() the IM
context after text is deleted or committed, but the Wayland IM does
apply its practical effects after these actions happen. This keeps
the Wayland IM fully up-to-date wrt text widget state, while not
altering the ::commit and ::delete-surrounding-text behavior for
other IM context implementations.

Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5200
Fixes: 5b78fe2721 (gtktextview: Also reset IM context after IM...)
Fixes: 7c0a395ff9 (gtktext: Also reset IM context after IM...)
Fixes: 52ac71b972 (gtktextview: Shuffle the places doing IM reset)
Fixes: 9e29739e66 (gtktext: Shuffle the places doing IM reset)
3 years agoDrop gdkintl.h
Matthias Clasen [Sat, 24 Sep 2022 03:33:42 +0000 (23:33 -0400)]
Drop gdkintl.h

This header was merely including gi18n-lib.h.
Just do that directly.

3 years agoRename gdk-private.h to gdkprivate.h
Matthias Clasen [Sat, 24 Sep 2022 03:23:27 +0000 (23:23 -0400)]
Rename gdk-private.h to gdkprivate.h

The extra - does not add any value.

3 years agoRename gdkconstructor.h to gdkconstructorprivate.h
Matthias Clasen [Sat, 24 Sep 2022 03:14:08 +0000 (23:14 -0400)]
Rename gdkconstructor.h to gdkconstructorprivate.h

This is the naming convention for private headers.

3 years agoRename gdkdebug.h to gdkdebugprivate.h
Matthias Clasen [Sat, 24 Sep 2022 03:11:41 +0000 (23:11 -0400)]
Rename gdkdebug.h to gdkdebugprivate.h

This is the naming convention for private headers.

3 years agogtk: Dissolve gtk-autocleanup.h
Matthias Clasen [Sat, 24 Sep 2022 01:54:15 +0000 (21:54 -0400)]
gtk: Dissolve gtk-autocleanup.h

Move the autocleanup declarations into their
respective headers.

3 years agogsk: Dissolve gsk-autocleanup.h
Matthias Clasen [Fri, 23 Sep 2022 23:40:42 +0000 (19:40 -0400)]
gsk: Dissolve gsk-autocleanup.h

Move the autocleanup declarations into their
respective headers.