Claudio Cambra [Wed, 9 Nov 2022 16:08:12 +0000 (17:08 +0100)]
Merge pull request #5118 from nextcloud/bugfix/remove-unused-var-user
Remove unused remotePath in User::processCompletedSyncItem
Claudio Cambra [Mon, 31 Oct 2022 19:19:36 +0000 (20:19 +0100)]
Remove unused remotePath in User::processCompletedSyncItem
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
allexzander [Wed, 9 Nov 2022 15:06:08 +0000 (16:06 +0100)]
Merge pull request #5148 from nextcloud/bugfix/qdialig-do-not-use-copy-assignment
Do not use copy-assignment of QDialog.
alex-z [Wed, 9 Nov 2022 15:01:17 +0000 (16:01 +0100)]
Do not use copy-assignment of QDialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Wed, 9 Nov 2022 03:20:17 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 17:17:29 +0000 (18:17 +0100)]
Merge pull request #5132 from nextcloud/bugfix/dark-mode-share-delegate-buttons
Fix share delegate button icon colors in dark mode
Claudio Cambra [Fri, 4 Nov 2022 19:05:36 +0000 (20:05 +0100)]
Fix share delegate button icon colors in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 16:33:10 +0000 (17:33 +0100)]
Merge pull request #5129 from nextcloud/bugfix/sync-now-button-elide
Ensure 'Sync now' button doesn't have its text elided
Claudio Cambra [Fri, 4 Nov 2022 12:05:55 +0000 (13:05 +0100)]
Ensure 'Sync now' button doesn't have its text elided
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 15:31:31 +0000 (16:31 +0100)]
Merge pull request #5127 from nextcloud/bugfix/remove-unused-app-ptr
Remove unused app pointer in CocoaInitializer
Claudio Cambra [Fri, 4 Nov 2022 01:30:39 +0000 (02:30 +0100)]
Remove unused app pointer in CocoaInitializer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Tue, 8 Nov 2022 03:21:23 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 7 Nov 2022 22:41:59 +0000 (23:41 +0100)]
Merge pull request #5104 from nextcloud/bugfix/doNotDeleteFilesInSyncDatabase
Bugfix/delete folders during propagation even when propagation has errors
Matthieu Gallien [Thu, 27 Oct 2022 15:29:02 +0000 (17:29 +0200)]
do not skip folder deletion if BlacklistedError during propagation
in case some propgation actions ends up with a BlacklistedError, we
would skip the deletions of local folders (even though they have been
deleted from server)
let's not skip them but rather keep track of the error status and
properly report them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 27 Oct 2022 16:00:10 +0000 (18:00 +0200)]
new autotest to ensure that we delete folders despite blacklist errors
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 27 Oct 2022 11:13:21 +0000 (13:13 +0200)]
improve logs of E2EE API to not pollute logs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 27 Oct 2022 10:49:34 +0000 (12:49 +0200)]
logs from discovery are now namespaced by nextcloud to show debug logs
use nextcloud namespace for discovery logs as it does not show correcly
without that
this is because we have central rules for all logs from nextcloud
namespace
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 26 Oct 2022 16:13:55 +0000 (18:13 +0200)]
remove dead code related to item renaming
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Mon, 7 Nov 2022 14:13:50 +0000 (15:13 +0100)]
Merge pull request #5136 from nextcloud/feature/config-name-in-cmake
Use separate variable for cfg file name in CMAKE.
alex-z [Mon, 7 Nov 2022 09:00:23 +0000 (10:00 +0100)]
Use separate variable for cfg file name in CMAKE.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Mon, 7 Nov 2022 03:20:00 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 6 Nov 2022 03:21:51 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 5 Nov 2022 03:25:03 +0000 (03:25 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 4 Nov 2022 13:34:48 +0000 (13:34 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
alex-z [Fri, 4 Nov 2022 11:05:11 +0000 (12:05 +0100)]
Revert "[tx-robot] updated from transifex"
This reverts commit
89c68c48dc50897f1d7a1c827ba156a60001bc93.
Nextcloud bot [Fri, 4 Nov 2022 03:20:29 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 3 Nov 2022 14:16:34 +0000 (15:16 +0100)]
Merge pull request #5123 from nextcloud/bugfix/remove-unused-internal-link-widget
Remove unused internal link widget from old share dialog
Claudio Cambra [Wed, 2 Nov 2022 16:27:49 +0000 (17:27 +0100)]
Remove unused internal link widget from old share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
allexzander [Thu, 3 Nov 2022 13:00:50 +0000 (14:00 +0100)]
Merge pull request #5092 from nextcloud/bugfix/incorrect-currentuserid
Fix incorrect current user index when adding or removing a user account. Also fix incorrect user avatar lookup by id.
allexzander [Tue, 25 Oct 2022 13:49:56 +0000 (16:49 +0300)]
Fix accounts avatar issue when it becomes completely white due to non-changing account id member with changing account index in the list.
Signed-off-by: allexzander <blackslayer4@gmail.com>
alex-z [Mon, 24 Oct 2022 13:36:53 +0000 (16:36 +0300)]
Fix incorrect current user index when removing and adding an account.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Thu, 3 Nov 2022 03:19:28 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 2 Nov 2022 03:21:25 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Tue, 1 Nov 2022 09:41:00 +0000 (10:41 +0100)]
Merge pull request #5067 from nextcloud/bugfix/e2e-do-not-generate-keys-without-request
E2EE. Do not generate keypair without user request.
allexzander [Fri, 14 Oct 2022 15:47:46 +0000 (18:47 +0300)]
E2EE. Do not generate keypair without user request.
Signed-off-by: allexzander <blackslayer4@gmail.com>
Nextcloud bot [Tue, 1 Nov 2022 03:20:33 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Mon, 31 Oct 2022 17:41:51 +0000 (18:41 +0100)]
Merge pull request #4929 from nextcloud/feature/qml-file-details
Add a new file details window, unify file activity and sharing
Claudio Cambra [Sun, 30 Oct 2022 11:56:11 +0000 (12:56 +0100)]
Change liveDialog to nullDialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 29 Oct 2022 17:24:54 +0000 (19:24 +0200)]
Update Kirigami WheelHandler to upstream v5.99.0
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 18 Oct 2022 18:31:32 +0000 (20:31 +0200)]
Add testing for SortedShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 18 Oct 2022 15:15:10 +0000 (17:15 +0200)]
Moved all server mocking code for share model test to independent ShareTestUtils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 17 Oct 2022 08:37:14 +0000 (10:37 +0200)]
Add testing for ShareeModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 6 Oct 2022 11:21:33 +0000 (13:21 +0200)]
Add a suite of tests for ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Test ShareModel error handling
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Improve testing of user/group shares in ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Add testing for maximum share expire date enforcement in ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 17 Oct 2022 19:49:12 +0000 (21:49 +0200)]
Filter out sharees that already have active shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Oct 2022 21:16:10 +0000 (23:16 +0200)]
Improve server error handling in the ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 3 Oct 2022 14:57:02 +0000 (16:57 +0200)]
Check for state of file record retrieval in fileactivitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 3 Oct 2022 08:47:27 +0000 (10:47 +0200)]
Fix default date parser handling of timezones
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 15:02:49 +0000 (17:02 +0200)]
Renamed _userStoppedTypingTimer to searchRateLimitingTimer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 15:00:31 +0000 (17:00 +0200)]
Add trailing comma to shareemodel enum
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 14:49:28 +0000 (16:49 +0200)]
Replace manual index bound checks with calls to checkIndex
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 13:52:53 +0000 (15:52 +0200)]
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 09:53:12 +0000 (11:53 +0200)]
Use auto where possible
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 09:47:36 +0000 (11:47 +0200)]
Add minimum size to file details window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 09:35:26 +0000 (11:35 +0200)]
Remove default cases in switches, rely on compiler warnings for missed cases
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 08:50:14 +0000 (10:50 +0200)]
Eliminate unneeded parent Item in FileActivityView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 08:37:02 +0000 (10:37 +0200)]
Add early return checks for setter methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 08:26:06 +0000 (10:26 +0200)]
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 30 Sep 2022 23:16:52 +0000 (01:16 +0200)]
Remove Q_REQUIRED_RESULT from method with side-effect where result not always required, and viceversa
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 30 Sep 2022 23:13:41 +0000 (01:13 +0200)]
Use [[nodiscard]] more broadly in methods returning values, and respect it elsewhere
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 17:55:25 +0000 (19:55 +0200)]
Show password set errors in the popup where passwords are set rather than in the main dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 16:25:41 +0000 (18:25 +0200)]
Improve share view tab buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 16:18:47 +0000 (18:18 +0200)]
Change 'Link share' to 'Share link', matching server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 16:18:12 +0000 (18:18 +0200)]
Improve flat buttons in share delegates
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 25 Jul 2022 16:57:18 +0000 (18:57 +0200)]
Add a file details window/page, QMLify file sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Mon, 31 Oct 2022 11:23:52 +0000 (12:23 +0100)]
add mising namespace
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 31 Oct 2022 10:00:07 +0000 (11:00 +0100)]
Merge pull request #5116 from nextcloud/ci/fixMacCompilationEditLocallly
use new public API to open an edit locally URL
Matthieu Gallien [Mon, 31 Oct 2022 09:28:47 +0000 (10:28 +0100)]
use new public API to open an edit locally URL
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Mon, 31 Oct 2022 03:19:19 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 30 Oct 2022 03:23:26 +0000 (03:23 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Sat, 29 Oct 2022 15:03:46 +0000 (17:03 +0200)]
Merge pull request #5097 from nextcloud/bugfix/sync-now-visible-connected
Only show Sync Now button if account is connected
Claudio Cambra [Wed, 26 Oct 2022 10:47:42 +0000 (12:47 +0200)]
Only show Sync Now button if account is connected
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 29 Oct 2022 13:44:21 +0000 (15:44 +0200)]
Merge pull request #5105 from nteodosio/master
Fix compatibility with newer python3-nautilus
Nathan Pratta Teodosio [Fri, 26 Aug 2022 18:03:03 +0000 (15:03 -0300)]
Fix compatibility with newer python3-nautilus
Signed-off-by: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
Claudio Cambra [Sat, 29 Oct 2022 12:37:29 +0000 (14:37 +0200)]
Merge pull request #5027 from nextcloud/bugfix/modernise-accountsettings-code
Modernise and improve code in AccountSettings
Claudio Cambra [Wed, 26 Oct 2022 20:04:34 +0000 (22:04 +0200)]
Modernise QString-related construction
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 20:01:33 +0000 (22:01 +0200)]
Add braces to all if statements missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Oct 2022 10:35:41 +0000 (12:35 +0200)]
Expand use of const and auto, improve readability of accountsettings
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Sat, 29 Oct 2022 12:02:04 +0000 (14:02 +0200)]
Merge pull request #5107 from nextcloud/bugfix/refactor-folderman-edit-locally
Refactor FolderMan's "Edit Locally" capabilities as separate class
Claudio Cambra [Sat, 29 Oct 2022 11:21:56 +0000 (13:21 +0200)]
Rename EditLocallyHandler to EditLocallyJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 22:19:04 +0000 (00:19 +0200)]
Ensure the checkTokenJob object gets deallocated
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 18:22:27 +0000 (20:22 +0200)]
Show edit locally loading dialog sooner, improve feedback for user
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 17:40:06 +0000 (19:40 +0200)]
Refactor edit locally handler management away from application and into own class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 14:43:30 +0000 (16:43 +0200)]
Don't show the user any potenitally questionable remote data
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 14:42:57 +0000 (16:42 +0200)]
Verify token before checking disk or modifying state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 18:13:38 +0000 (20:13 +0200)]
Refactor edit locally into its own class, rather than bolting onto FolderMan
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 17:10:21 +0000 (19:10 +0200)]
Refactor large editFileLocally FolderMan method into smaller, clearer separate methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Sat, 29 Oct 2022 03:31:52 +0000 (03:31 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 11:11:01 +0000 (13:11 +0200)]
Merge pull request #5093 from nextcloud/work/validate-edit-locally-token
Validate and sanitise edit locally token and relpath before sending to server
Claudio Cambra [Thu, 27 Oct 2022 14:32:51 +0000 (16:32 +0200)]
Use addQueryParams for checkTokenForEditLocally SimpleApiJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 14:07:59 +0000 (16:07 +0200)]
Make sure to check relPath and compare to canonical cleaned path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 17:19:43 +0000 (19:19 +0200)]
Make sure to encode the relPath
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 13:56:53 +0000 (15:56 +0200)]
Validate edit locally token before sending to server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 28 Oct 2022 03:20:17 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 27 Oct 2022 13:56:46 +0000 (15:56 +0200)]
Merge pull request #5102 from nextcloud/bugfix/fix-mac-autoupdater-settings
Fix macOS autoupdater settings
Claudio Cambra [Thu, 27 Oct 2022 12:30:33 +0000 (14:30 +0200)]
Fix macOS autoupdater settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Thu, 27 Oct 2022 03:19:41 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 17:11:33 +0000 (19:11 +0200)]
Merge pull request #5026 from nextcloud/bugfix/modernise-account-code
Modernise and improve code in AccountManager
Claudio Cambra [Mon, 10 Oct 2022 10:02:22 +0000 (12:02 +0200)]
Constexpr settings constant strings, expand use of const and auto, modernise, in accountsmanager
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Nextcloud bot [Wed, 26 Oct 2022 03:21:16 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 19:33:08 +0000 (21:33 +0200)]
Merge pull request #5018 from nextcloud/feature/force-sync-tray-button
Add a 'Sync now' button to the sync status header in the tray window
projects / nextcloud-desktop.git / log