dgit.raspbian.org Git - samba.git/log

Merge samba (2:4.19.5+dfsg-1) import into refs/heads/workingbranch

silence "Can not convert group sid" warnings in the log

Forwarded: yes

/var/log/samba/log.winbind is full of messages like:

[2024/02/09 06:25:04.788182, 1, pid=74620] source3/winbindd/winbindd_getgroups.c:259(winbindd_getgroups_recv)
Could not convert sid S-0-0: NT_STATUS_NONE_MAPPED

On a busy server these are logged several 1000s times per minute,
making any other messages basically invisible.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Gbp-Pq: Name silence-can-not-convert-group-sid.diff

ctdb: use /run/ctdb instead of /var/run/ctdb

Whole upstream path assignment needs a review.

Gbp-Pq: Name ctdb-use-run-instead-of-var-run.patch

print meaningful error message if python3-markdown is not installed

Gbp-Pq: Name meaningful-error-if-no-python3-markdown.patch

print meaningful error message if samba-ad-provision is not installed

Gbp-Pq: Name meaningful-error-if-no-samba-ad-provision.patch

[PATCH] fruit: disable useless size_t overflow check

From e4bf63c976b0e3253f980360b2fe6244092b777c Mon Sep 17 00:00:00 2001
Bug-Debian: http://bugs.debian.org/974868

As has been said several times in
https://bugzilla.samba.org/show_bug.cgi?id=13622 ,
the check 'bandsize > SIZE_MAX/nbands' is useless. But it
is also wrong, in 2 ways: first, nbands might be 0 (when
no bands has been allocated yet), and second, there's no
point in comparing this with SIZE_MAX, since size_t on 32bit
platforms is a 32bit integer, while bandsize is off_t which
is 64bits (samba always enables LFS).

This check causes the module to fail when bandsize*nbands
exceeds 32bits, which has been reported for example at
https://bugs.debian.org/974868 .

Whole thing can't overflow because it is already guarded
by time_machine_max_size. Or at the very least, by current
disk sizes... :)

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Gbp-Pq: Name fruit-disable-useless-size_t-overflow-check.patch

Heimdal: spelling fixes (underun prefered relase encyption confunder)

Gbp-Pq: Name heimdal-spelling.patch

add missing libs deps

Bug-Debian: https://bugs.debian.org/1010922

Lots of samba libraries has incomplete dependencies listed
in wscript files. This usually is not a problem since the
link line includes dependencies of their dependencies of
their dependencies, and somewhere down that line all immediate
dependencies which are missing are actually present. But
sometimes this becomes a problem when a library does not
declare direct dependency on at least one private library
which it actually uses: in case no private library is
listed as direct dependency, private library directory is
not put into RUNPATH of the resulting binary, so the binary
can not find its own dependencies.

Fix a few such places, including one library which is a part
of public abi (libsmbldap).

Gbp-Pq: Name add-missing-libs-deps.diff

testparm: do not fail if /run/samba does not exist

testparm explicitly fails if $piddir or $lockdir does not exist.
However, the daemons which actually use these directories, will
create it on demand, there is no need to fail even simple testparm
operations if the dirs are not there.

This change lets to (pre)configure samba without bothering to
pre-create the directories which are overwise needed only to fulfil
testparm criteria.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Gbp-Pq: Name testparm-do-not-fail-if-pid-dir-does-not-exist.patch

move msg.sock from /var/lib/samba to /run/samba

This moves a socket directory from /var/lib/samba to /run/samba.

https://lists.samba.org/archive/samba-technical/2022-April/137322.html

Gbp-Pq: Name move-msg.sock-from-var-lib-samba-to-run-samba.patch

disable setuid configure checks

For some strange reason, when running reprotest test on salsa-ci,
which apparently is running as root, - on the *second* build only
the configure fails (after successfully built package the first
time). The configure test tries to change gid and verifies it
actually changed (not that the syscall exist), - and that fails.
Since it is extremely uncommon to configure the build process as
root, salsa-ci test environment details are quite deep down the line,
and we know the syscall actually works, just disable the probe,
pretending we are not root.

Gbp-Pq: Name disable-setuid-confchecks.patch

silence uselib_local warning produced by waf

During config/build process in verbose mode, waf produces
about 2k repetitions of this warning:

compat: "uselib_local" is deprecated, replace by "use"

which clutters the build log.

Comment this warning out for now until it will be
fixed properly.

Gbp-Pq: Name silence-waf-uselib_local.diff

create ctdb pid directory

(which is /run/ctdb/). Create it in the systemd service
file (using RuntimeDirectory directive) and in the sysv-init
script.

Gbp-Pq: Name ctdb-create-piddir.patch

fix pathname for ctdb_etcd_lock

Specify the actual installation path for this helper script.

Gbp-Pq: Name ctdb_etcd_lock-path.patch

use bzero() instead of memset_s()

lib/replace/replace.h header defines ZERO_STRUCT macro
which uses memset_s() function (which is similar to
memset() but can not be optimized out by the compiler).
Glibc has bzero() with similar property, while memset_s()
have is implemented in lib/replace/replace.c, - this way,
some binaries needlessly link with libreplace-samba4 just
to get rep_memset_s() symbol. By using bzero() instead,
this endless linkage is eliminated, so we can package,
for example, libldb (which uses ZERO_STRUCT) without it
linking to libreplace-samba4.

Note: actually using explicit_bzero() so it is not optimized
out by the compiler - this is the original goal of using
memset_s().

Gbp-Pq: Name use-bzero-instead-of-memset_s.diff

[PATCH] Force LDB as standalone

Gbp-Pq: Name Force-LDB-as-standalone.patch

ctdb-config-enable-syslog-by-default

ctdb-config: enable syslog by default

CTDB uses /var/log/ctdb/ directory for the default log files. With
syslog disabled, systemd journal is not able to correctly inform
errors happening during service initialization.

Upstream community creates generic config files to be used by different
distributions, so this change makes no big difference to be accepted by
upstream.

With this patch the end user will be able to identify initialization
errors by executing:

systemctl status ctdb.service

or to follow ctdb logs by executing:

journalctl -f -u ctdb

Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
-
Author: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
Bug-Debian: https://bugs.debian.org/929931
Bug-Ubuntu: https://bugs.launchpad.net/bugs/722201
Last-Update: 2022-03-24

Gbp-Pq: Name ctdb-config-enable-syslog-by-default.patch

fix nfs related service names

Upstream defines nfs related service names based on the Linux
distribution. This patch fixes the names for Debian and derivatives.

Update by Andreas Hasenack <andreas@canonical.com> (LP: #1961840):
Use nfsconf(8) if it's available, instead of parsing the old config
files in /etc/default/nfs-*

Bug-Debian: https://bugs.debian.org/929931
Bug-Ubuntu: https://bugs.launchpad.net/bugs/722201
Last-Update: 2022-09-09

Gbp-Pq: Name fix-nfs-service-name-to-nfs-kernel-server.patch

[PATCH] smbd.service: Run update-apparmor-samba-profile before start

Bug-Debian: https://bugs.debian.org/896080

Gbp-Pq: Name smbd.service-Run-update-apparmor-samba-profile-befor.patch

Add so version number to private libraries for dpkg-shlibdeps

We also want dpkg-shlibdeps to generate correct dependency information
for the private libraries in our binary packages, but dpkg-shlibdeps
only works when the library has a version number.

Origin: vendor
Forwarded: not-needed

Gbp-Pq: Name add-so-version-to-private-libraries

Patch in symbol table from rfc3454, for Heimdal scripts

Forwarded: not-needed

Status: cherry-picked from heimdal package

Gbp-Pq: Name heimdal-rfc3454.txt

Enable net usershares by default at build time

Enable net usershares by default at build time, with a limit of 100, and update
the corresponding documentation.

Bug-Debian: http://bugs.debian.org/443230
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/128548
Forwarded: not-needed

Gbp-Pq: Name usershare.patch

Use the pager alternative as pager is PAGER is undefined

Bug-Debian: http://bugs.debian.org/135603
Forwarded: not-needed

Gbp-Pq: Name smbclient-pager.patch

Mention smbldap-tools package in examples/LDAP/README

Bug-Debian: http://bugs.debian.org/341934
Forwarded: not-needed

Gbp-Pq: Name README_nosmbldap-tools.patch

hurd compatibility changes

Hurd does not define PIPE_BUF, so lib/tevent/testsuite.c fails to compile
(yes, this file is used as part of *samba* testsuite, not tevent testsuite).
Define it to a safe minimal value like 512 bytes.

Hurd does not provide SA_NOCLDWAIT define, so lib/util/tests/tfork.c does
not compile. This is only needed during testing to omit zombie process
generation, which has only cosmetic effect. Define it to be 0.

Based on prior work and ideas by Samuel Thibault.

Gbp-Pq: Name hurd-compat.patch

ensure libsmbclient.h is being used with LFS enabled

Bug-Debian: https://bugs.debian.org/221618

We build samba with LFS (Large File Support) even on 32bits.
This means some types like off_t are 64-bit wide, again,
even on a 32bit host.  libsmbclient.h uses off_t in function
prototypes, and thes prototypes muct match those which were
used at samba compile time - if some other source includes
libsmbclient.h without LFS, it'll get wrong prototypes and
the resulting binary will most likely crash when using
libsmbclient functions.

Detect and error-out this at compile time.

We can not do anything with this in the public header since
it is alredy too late to redefine things, since we can't
guarantee we're the first header a program #includes, and
at the time this libsmbclient.h is included, off_t can
already be defined so our (re)define of _FILE_OFFSET_BITS
does nothing already.

Patching libsmbclient.h to use off64_t means client program
should change their off_t to off64_t too when storing
file offsets returning from libsmbclient, so this is not
an option too.

With this change, we will error out even if the user source
does not use any off_t-related functions. Namely, it was ok
to #include <libsmbclient.h> and use smbc_open/smbc_read/
smbc_write/smbc_close without _F_O_B=64, - neither of these
functions uses off_t. smbc_lseek and others doesn't work,
but if a program does not use them anyway, whole thing will
just work even without enabling LFS.  Ideally we can probably
check each individual function which is being affected, by
replacing it with #error if sizeof(off_t) < 8.  But this
requires quite some hackery...

Gbp-Pq: Name libsmbclient-ensure-lfs-221618.patch

samba (2:4.19.5+dfsg-1) unstable; urgency=medium

  * new upstream stable/bugfix release (4.19.5)
  * reformat previous changelog entry to fit in 80cols
  * d/winbind.postrm: stop recursively removing plain files
  * d/winbind.postrm: winbindd_cache.tdb is in /var/lib now,
    not in /var/cache
  * d/control: RulesRequiresRoot:no
  * d/*.symbols: use #PACKAGE# placeholders where appropriate
    (or add comments where it is not)
  * +silence-can-not-convert-group-sid.diff -
    make another log message less annoying
  * -python-fix-invalid-escape-sequences.patch (applied upstream)
  * d/control: replace pkg-config=>pkgconf in Build-Depends, remove
    pkg-config from Depends of libldb-dev and python3-ldb-dev
  * d/samba-libs.symbols, d/control: make libsmbldapN a virtual package
    provided by samba-libs too, like libndrN

[dgit import unpatched samba 2:4.19.5+dfsg-1]

Import samba_4.19.5+dfsg.orig.tar.xz

[dgit import orig samba_4.19.5+dfsg.orig.tar.xz]

Import samba_4.19.5+dfsg-1.debian.tar.xz

[dgit import tarball samba 2:4.19.5+dfsg-1 samba_4.19.5+dfsg-1.debian.tar.xz]

Merge samba (2:4.19.4+dfsg-3) import into refs/heads/workingbranch

python: Fix invalid escape sequences

Origin: upstream, https://gitlab.com/samba-team/samba/-/commit/b068592dd0dccce634cb17b66f0659ba60523908
Comment: mjt: remove 1 hunk from python/samba/tests/gpo.py not present in 4.19
Bug-Debian: https://bugs.debian.org/1057668

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Gbp-Pq: Name python-fix-invalid-escape-sequences.patch