Matthias Clasen [Fri, 27 Dec 2019 04:49:26 +0000 (23:49 -0500)]
applicationwindow: Stop using a menu bar
We have a replacement with popovers now.
Matthias Clasen [Fri, 27 Dec 2019 13:47:12 +0000 (08:47 -0500)]
notebook: Remove menu remnants
Matthias Clasen [Thu, 26 Dec 2019 15:06:08 +0000 (10:06 -0500)]
appchooserwidget: Remove ::populate-popup
We are no longer doing menus this way; if a menu turns out to be
needed at all here, we can add a menu model later.
Matthias Clasen [Fri, 27 Dec 2019 01:10:34 +0000 (20:10 -0500)]
placesview: Use a popover
Replace the context menu with a popover.
Matthias Clasen [Thu, 26 Dec 2019 18:09:04 +0000 (13:09 -0500)]
mountoperation: Use a popover
Replace the context menu with a popover.
Matthias Clasen [Thu, 26 Dec 2019 14:29:36 +0000 (09:29 -0500)]
filechooserbutton: Be smarter about 'None'
Don't refilter the model while the combo box is popped up,
that wreaks havoc with layout and does not really work.
Instead, repurpose one of the separator rows for the 'none'
case. This works because the row separator function is not
consulted for the cellview in the button.
Matthias Clasen [Sat, 28 Dec 2019 05:08:29 +0000 (00:08 -0500)]
window: Complete the popover conversion
Matthias Clasen [Sat, 28 Dec 2019 14:42:43 +0000 (09:42 -0500)]
popovermenubar: Cosmetics
Matthias Clasen [Fri, 27 Dec 2019 06:31:25 +0000 (01:31 -0500)]
popovermenu: Use a weak ref for active item
Otherwise, we can end up with a dangling pointer,
leading to badness.
Matthias Clasen [Sun, 29 Dec 2019 18:31:36 +0000 (13:31 -0500)]
surface: Only unpause events if we paused them
When a new popup surface is created, it may end up
getting a resume-events signal from its frame clock
without having seen a flush-events first.
Don't unpause events in that case, since it messes
up the displays pause counter.
This was causing criticals with tooltips.
Matthias Clasen [Sun, 29 Dec 2019 17:49:17 +0000 (12:49 -0500)]
Revert unintended changes
I didn't mean to make this a complicated
portal test. Go back to being a simple test.
Matthias Clasen [Sun, 29 Dec 2019 02:52:34 +0000 (21:52 -0500)]
Remove more mir remnants
The mir backend was removed a while ago, so
GDK_WINDOWING_MIR is never defined.
Matthias Clasen [Sun, 29 Dec 2019 02:49:09 +0000 (21:49 -0500)]
tooltip: Remove some unneeded includes
Matthias Clasen [Sun, 29 Dec 2019 02:04:42 +0000 (21:04 -0500)]
popover: Remove some dead code
Aurimas Černius [Sat, 28 Dec 2019 16:18:53 +0000 (18:18 +0200)]
Updated Lithuanian translation
Matthias Clasen [Sat, 28 Dec 2019 03:52:08 +0000 (22:52 -0500)]
popovermenu: Fix keynav with submenus
When we right-arrow all the way into a submenu
and then cycle to the next menu in a menubar,
we need to reset all open submenus, so that
left-arrowing back to the menu puts the focus
on the first item again.
Matthias Clasen [Sat, 28 Dec 2019 02:58:54 +0000 (21:58 -0500)]
modelbutton: Be focusable
This got lost when modelbuttons stopped being
derived from buttons. It is necessary, since
the GTK focus machinery takes this flag seriously
nowadays, and won't let us grab focus to non-focusable
widgets.
Matthias Clasen [Fri, 27 Dec 2019 17:16:14 +0000 (12:16 -0500)]
inspector: Add a focus overlay
It helps to see what is going on.
Fran Dieguez [Fri, 27 Dec 2019 14:42:53 +0000 (14:42 +0000)]
Update Galician translation
Jordi Mas [Fri, 27 Dec 2019 13:06:32 +0000 (14:06 +0100)]
Fixes to Catalan translation
Piotr Drąg [Wed, 25 Dec 2019 15:36:41 +0000 (16:36 +0100)]
Update Polish translation
Matthias Clasen [Wed, 25 Dec 2019 05:40:32 +0000 (00:40 -0500)]
widget: Fix a memory leak
The transform passed to gtk_widget_allocate is
transfer full, so we must consume the reference
before returning.
Matthias Clasen [Wed, 25 Dec 2019 01:06:57 +0000 (20:06 -0500)]
widget: Avoid a crash in event handling
I was seeing crashes in gtk_widget_run_controllers.
We were accessing the controller after calling out
to application code that might remove it. Better
be safe and do the access before.
Matthias Clasen [Wed, 25 Dec 2019 00:42:14 +0000 (19:42 -0500)]
inspector: Fix a small memory leak
We were leaking overlays.
Matthias Clasen [Wed, 25 Dec 2019 00:40:50 +0000 (19:40 -0500)]
inspector: Fix a small memory leak
The property editor was leaking a few GValues.
Matthias Clasen [Wed, 25 Dec 2019 00:40:19 +0000 (19:40 -0500)]
inspector: Small cleanup
Matthias Clasen [Wed, 25 Dec 2019 00:39:37 +0000 (19:39 -0500)]
widget: Fix a small memory leak
Matthias Clasen [Wed, 25 Dec 2019 00:39:10 +0000 (19:39 -0500)]
eventcontroller: Fix name property
This never worked. Oops.
Matthias Clasen [Sun, 22 Dec 2019 01:57:28 +0000 (20:57 -0500)]
testfilechooser: Test the choice apis
Fran Dieguez [Wed, 25 Dec 2019 04:05:00 +0000 (04:05 +0000)]
Update Galician translation
Fran Dieguez [Wed, 25 Dec 2019 03:16:43 +0000 (03:16 +0000)]
Update Galician translation
Matthias Clasen [Tue, 24 Dec 2019 17:41:38 +0000 (17:41 +0000)]
Merge branch 'print-dialog-fixes' into 'master'
Print dialog fixes
See merge request GNOME/gtk!1268
Matthias Clasen [Tue, 24 Dec 2019 17:29:38 +0000 (12:29 -0500)]
Adwaita: update the README
Matthias Clasen [Tue, 24 Dec 2019 17:29:16 +0000 (12:29 -0500)]
HighContrast: print dialog fixes
Fix up the paper drawing.
Matthias Clasen [Tue, 24 Dec 2019 17:28:45 +0000 (12:28 -0500)]
Adwaita: print dialog tweaks
Fix up the paper drawing.
Matthias Clasen [Tue, 24 Dec 2019 17:28:00 +0000 (12:28 -0500)]
print dialog: Fix up page drawing
This fixes up page drawing enough to appear properly
with the builtin themes.
Matthias Clasen [Tue, 24 Dec 2019 15:08:15 +0000 (15:08 +0000)]
Merge branch 'widget-factory-fixes' into 'master'
Widget factory fixes
See merge request GNOME/gtk!1267
Matthias Clasen [Tue, 24 Dec 2019 14:59:23 +0000 (09:59 -0500)]
widgetfactory: Undo more builder-tool damage
The two volume buttons are supposed to be
vertically arranged.
Matthias Clasen [Tue, 24 Dec 2019 14:58:56 +0000 (09:58 -0500)]
Fix the build
Matthias Clasen [Tue, 24 Dec 2019 08:47:28 +0000 (08:47 +0000)]
Merge branch 'gtk-demo-fixes' into 'master'
Gtk demo fixes
See merge request GNOME/gtk!1266
Matthias Clasen [Tue, 24 Dec 2019 08:39:02 +0000 (03:39 -0500)]
treeview: Fix embedding cell renderers
We need to manually set up the css node,
since the treeview has children whose css
node is not a direct child of the treeview
css node (header buttons).
Matthias Clasen [Tue, 24 Dec 2019 08:33:02 +0000 (03:33 -0500)]
cell renderer spin: Bring this back
GtkSpinButton lost its cell editable implementation
when it stopped being a GtkEntry subclass. Add it
back, and make it work.
Matthias Clasen [Tue, 24 Dec 2019 08:13:58 +0000 (03:13 -0500)]
cell renderer text: Fix this to work again
We were showing the entry, and removing it right
away when the focus moved to the text child.
Avoid that.
Matthias Clasen [Tue, 24 Dec 2019 08:12:30 +0000 (03:12 -0500)]
paper dialog: Make this look less horrible
Matthias Clasen [Tue, 24 Dec 2019 04:17:29 +0000 (23:17 -0500)]
accelgroup: Fix a buffer overrun
gtk_accelerator_parse_with_keycode can
overrun its buffer for certain inputs.
Fixes: https://gitlab.gnome.org/GNOME/gtk/issues/2325
Matthias Clasen [Tue, 24 Dec 2019 03:49:48 +0000 (03:49 +0000)]
Merge branch 'drop-GtkTreeViewPrivate' into 'master'
tree-view: Drop GtkTreeViewPrivate
See merge request GNOME/gtk!1240
Matthias Clasen [Tue, 24 Dec 2019 03:48:18 +0000 (03:48 +0000)]
Merge branch 'drop-gtk-tree-selection-private' into 'master'
tree-selection: Drop GtkTreeSelectionPrivate
See merge request GNOME/gtk!1256
Matthias Clasen [Tue, 24 Dec 2019 03:47:15 +0000 (03:47 +0000)]
Merge branch 'wip/oholy/placesview-default-location' into 'master'
placesview: Always open default location after mounting
See merge request GNOME/gtk!1263
Matthias Clasen [Tue, 24 Dec 2019 03:35:44 +0000 (22:35 -0500)]
gtk-demo: Fix font explore initial state
Matthias Clasen [Tue, 24 Dec 2019 03:33:02 +0000 (22:33 -0500)]
gtk-demo: Fix a crash in the font explorer demo
gtk_widget_add_controller is transfer-full.
Matthias Clasen [Tue, 24 Dec 2019 03:14:52 +0000 (22:14 -0500)]
gtk-demo: Cosmetic fixes to the dnd demo
Matthias Clasen [Tue, 24 Dec 2019 02:58:45 +0000 (21:58 -0500)]
gtk-demo: Cosmetic fixes to the assistant demo
Matthias Clasen [Tue, 24 Dec 2019 02:44:56 +0000 (21:44 -0500)]
gtk-demo: Fix the application demo
This was broken in
d223752c55be49, when the
support for internal children was removed
from GtkInfoBar.
Matthias Clasen [Mon, 23 Dec 2019 23:40:43 +0000 (23:40 +0000)]
Merge branch 'validate-templates' into 'master'
builder-tool: Validate templates again
See merge request GNOME/gtk!1265
Matthias Clasen [Mon, 23 Dec 2019 22:59:15 +0000 (17:59 -0500)]
builder-tool: Validate templates again
This wasn't working because it was expecting
some no-longer-existing error message.
Matthias Clasen [Mon, 23 Dec 2019 18:36:32 +0000 (13:36 -0500)]
colorchooser: Document actions
This is mainly a trial balloon for gtk-doc
support for this syntax.
See https://gitlab.gnome.org/GNOME/gtk-doc/merge_requests/30
Matthias Clasen [Sun, 22 Dec 2019 19:02:37 +0000 (19:02 +0000)]
Merge branch 'inspector-advice' into 'master'
inspector: Give better advice
See merge request GNOME/gtk!1264
Matthias Clasen [Sat, 21 Dec 2019 18:25:57 +0000 (13:25 -0500)]
inspector: Give better advice
Provide the meson syntax for building a debug-enabled GLib.
Christoph Reiter [Thu, 19 Dec 2019 17:59:40 +0000 (17:59 +0000)]
Merge branch 'ci-msys2-newer-pango' into 'master'
CI: Install a newer MSYS2 pango package; Don't allow failures again
Closes #2243
See merge request GNOME/gtk!1258
Ondrej Holy [Thu, 19 Dec 2019 15:49:07 +0000 (16:49 +0100)]
placesview: Always open default location after mounting
The default location (obtained over g_mount_get_default_location) is
opened after mounting volume, or when opening mounts from sidebar, but
not after mounting over "Connect to Server". Let's unify the behavior
and always open the default location.
https://gitlab.gnome.org/GNOME/nautilus/issues/1319
Matthias Clasen [Thu, 19 Dec 2019 03:42:31 +0000 (03:42 +0000)]
Merge branch 'fix-gtkgesturerotate-potential-leak' into 'master'
gtkgesturerotate: Fix a memory leak
See merge request GNOME/gtk!1260
Yariv Barkan [Wed, 18 Dec 2019 21:03:19 +0000 (23:03 +0200)]
gtkgesturerotate: Fix a memory leak
On touchpads gtk_gesture_get_sequences() was called without a
corresponding g_list_free(). The same was true for touchscreens
if due to some reason only a single sequence was found.
Christoph Reiter [Tue, 17 Dec 2019 19:23:28 +0000 (20:23 +0100)]
CI: Install a newer MSYS2 pango package; Don't allow failures again
gtk master requires a newer pango than msys2 has, so install our own copy on top.
See #2243
Christoph Reiter [Tue, 17 Dec 2019 19:46:36 +0000 (20:46 +0100)]
Fix various new mingw compiler warnings
These are the result of us missing CI for some time now and
MSYS2 having a newer GCC now I guess.
Peter Bloomfield [Tue, 17 Dec 2019 01:54:23 +0000 (20:54 -0500)]
tree-selection: Drop GtkTreeSelectionPrivate
GtkTreeSelection is now private (since commit
79940b32),
so it doesn't need an instance-private structure.
Emmanuele Bassi [Mon, 16 Dec 2019 19:26:37 +0000 (19:26 +0000)]
Merge branch 'ci-update-at-spi' into 'master'
Update CI image
Closes #2313
See merge request GNOME/gtk!1254
Emmanuele Bassi [Mon, 16 Dec 2019 19:01:03 +0000 (19:01 +0000)]
ci: Use latest CI image
Emmanuele Bassi [Mon, 16 Dec 2019 19:00:02 +0000 (19:00 +0000)]
ci: Add libXtst-devel to the Docker image
New requirement from at-spi2-core.
Fixes: #2313
Matthias Clasen [Mon, 16 Dec 2019 17:38:56 +0000 (17:38 +0000)]
Merge branch 'fix.nonunix.builds' into 'master'
Fix non-portal (UNIX) builds
See merge request GNOME/gtk!1252
Chun-wei Fan [Mon, 16 Dec 2019 10:03:24 +0000 (18:03 +0800)]
tests/: Revert
bbb56d8 for non-UNIX
The portal bits are only supported on *nix, so use the old code on
non-*nix.
Chun-wei Fan [Sat, 14 Dec 2019 03:13:21 +0000 (11:13 +0800)]
gdk: Build portal bits on *nix only
The newly-added portal items are supported on *nix only, so only build
them on *nix.
Matthias Clasen [Mon, 16 Dec 2019 16:48:01 +0000 (16:48 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
file transfer: Fix build on non-Linux
See merge request GNOME/gtk!1253
Matthias Clasen [Mon, 16 Dec 2019 16:28:21 +0000 (11:28 -0500)]
file transfer: Fix build on non-Linux
O_PATH and O_CLOEXEC are not universally available.
Peter Bloomfield [Wed, 11 Dec 2019 02:01:18 +0000 (21:01 -0500)]
tree-view: Drop GtkTreeViewPrivate
GtkTreeView is now private, so it doesn't need an instance-private
structure.
Benjamin Otte [Tue, 15 Oct 2019 01:23:05 +0000 (03:23 +0200)]
popover: Remove unneeded vfunc
The vfunc is identical to the GtkWidget implementation it replaces. So
just keep using that one.
Benjamin Otte [Fri, 13 Dec 2019 06:45:57 +0000 (07:45 +0100)]
treelistmodel: Improve docs
- Move into its own section
- Split GtkTreeListRow into its own document
Trees are weird with listmodels and they deserve their own treatment,
they shouldn't be mushed up with the rest of the list machinery.
Benjamin Otte [Sun, 15 Dec 2019 19:25:42 +0000 (20:25 +0100)]
eventcontrollermotion: Add getters for the properties
... and use them.
Also, rename them from is/contains-pointer-focus to is/contains-pointer,
that's clear enough and not too long.
Finally, adapt the semantics of contains-pointer to mirror
GtkEventControllerKey::contains-focus. If is-pointer is set, so is
contains-pointer, they are not exclusive.
Which is what all users of this property wanted, too.
Matthias Clasen [Fri, 13 Dec 2019 20:02:43 +0000 (20:02 +0000)]
Merge branch 'fix-x11-cursor-crash' into 'master'
x11: Only update cursors if we have any
Closes #2308
See merge request GNOME/gtk!1249
Matthias Clasen [Fri, 13 Dec 2019 19:58:53 +0000 (19:58 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
some builder-tool improvements
See merge request GNOME/gtk!1248
Matthias Clasen [Fri, 13 Dec 2019 19:46:00 +0000 (14:46 -0500)]
x11: Only update cursors if we have any
We were accessing an on-demand created hash table
without checking if it had been created first.
Fixes: https://gitlab.gnome.org/GNOME/gtk/issues/2308
Matthias Clasen [Fri, 13 Dec 2019 18:35:57 +0000 (13:35 -0500)]
builder: Improve type name mangling
When looking for the get_type function for GThemedIcon,
try both g_themed_icon_get_type and gthemed_icon_get_type
The former is what gio has, the latter is still supported
to avoid breaking gweather_location_get_type.
Update tests to cover this new case.
Matthias Clasen [Fri, 13 Dec 2019 18:11:59 +0000 (13:11 -0500)]
builder-tool: Don't try to find default boxed values
This doesn't work and yields an ugly, unnecessary
error message.
Matthias Clasen [Fri, 13 Dec 2019 07:05:11 +0000 (02:05 -0500)]
gtk-builder-tool: More helpful error messages
Include line numbers in the error messages we
report, so it is possible to find the error.
Marek Kasik [Fri, 13 Dec 2019 16:52:21 +0000 (17:52 +0100)]
printing: Fill device URI for non-Avahi printers
Device URI was not filled for non-Avahi printers by my previous commit.
I've added it back. It was a mistake during rebasing of the patch
to current master.
Matthias Clasen [Fri, 13 Dec 2019 16:13:17 +0000 (16:13 +0000)]
Merge branch '1509-don-t-show-Rejecting-Jobs-when-we-don-t-know' into 'master'
Fix getting info for standalone IPP printers
Closes #1509
See merge request GNOME/gtk!1247
Daniel Mustieles [Fri, 13 Dec 2019 11:24:36 +0000 (12:24 +0100)]
Updated Spanish translation
Matthias Clasen [Thu, 12 Dec 2019 23:46:53 +0000 (18:46 -0500)]
gtk-demo: Some touchups
Make the theming style classes demo look a bit less odd.
Matthias Clasen [Thu, 12 Dec 2019 23:37:39 +0000 (18:37 -0500)]
Run gtk-builder-tool simplify over our ui files
This was done mainly to verify that the tool does not
make any unwarranted changes. The changes included here
are all cosmetic.
Matthias Clasen [Thu, 12 Dec 2019 23:21:16 +0000 (18:21 -0500)]
Add GtkNative to the docs
It was not included in the generated docs.
Matthias Clasen [Thu, 12 Dec 2019 23:18:49 +0000 (18:18 -0500)]
Fix up GtkBuilderScope docs
They were not hooked into the document generation.
Matthias Clasen [Thu, 12 Dec 2019 22:58:42 +0000 (17:58 -0500)]
builder: Another small docs fix
Matthias Clasen [Thu, 12 Dec 2019 22:58:23 +0000 (17:58 -0500)]
docs: Ignore more private headers
Matthias Clasen [Thu, 12 Dec 2019 22:34:41 +0000 (17:34 -0500)]
docs: Remove symbols that no longer exist
Matthias Clasen [Thu, 12 Dec 2019 22:53:36 +0000 (22:53 +0000)]
Merge branch 'issue-179' into 'master'
Use a separate gesture for middle clicks on PlaceView rows
Closes #179
See merge request GNOME/gtk!1199
Matthias Clasen [Thu, 12 Dec 2019 22:31:13 +0000 (17:31 -0500)]
textbuffer: Minor doc fixes
Fix parameter name mismatches.
Matthias Clasen [Thu, 12 Dec 2019 22:30:36 +0000 (17:30 -0500)]
builder: Minor doc fixes
Fix parameter name mismatches.
Matthias Clasen [Thu, 12 Dec 2019 20:36:08 +0000 (20:36 +0000)]
Merge branch 'wip/otte/builder' into 'master'
More builder work
Closes #2267
See merge request GNOME/gtk!1230
Matthias Clasen [Thu, 12 Dec 2019 19:33:02 +0000 (19:33 +0000)]
Merge branch 'file-transfer' into 'master'
clipboard: file transfer portal support
See merge request GNOME/gtk!1244
Matthias Clasen [Mon, 3 Sep 2018 22:36:56 +0000 (18:36 -0400)]
clipboard: file transfer portal support
Implement file-list <-> application/vnd.flatpak.file-list
serialization by talking to the file transfer portal.
See https://github.com/flatpak/xdg-desktop-portal/pull/222
Matthias Clasen [Thu, 12 Dec 2019 19:18:06 +0000 (19:18 +0000)]
Merge branch 'master-gitlab-HC-tooltip' into 'master'
Set HighContrast tooltip back to black text over white background
See merge request GNOME/gtk!1242