Claudio Cambra [Mon, 9 Jan 2023 16:11:33 +0000 (17:11 +0100)]
Don't try to lock folders when editing locally
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 23 Jan 2023 16:46:16 +0000 (17:46 +0100)]
Merge pull request #5322 from nextcloud/bugfix/old-migration-fix
Fix migration from legacy client when override server url is set
Claudio Cambra [Wed, 11 Jan 2023 18:22:56 +0000 (19:22 +0100)]
Correctly parse account server url when migration from legacy config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 11 Jan 2023 17:17:03 +0000 (18:17 +0100)]
Stop checking config to migrate at current path if could not read file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 11 Jan 2023 15:58:48 +0000 (16:58 +0100)]
More concisely clean paths of trailing slash URLs in restore old config migration method of AccountManager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 23 Jan 2023 15:28:39 +0000 (16:28 +0100)]
Merge pull request #5361 from nextcloud/bugfix/update-copyright-years
Update legal notice to 2023
Claudio Cambra [Mon, 23 Jan 2023 14:33:29 +0000 (15:33 +0100)]
Update legal notice text
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 23 Jan 2023 14:31:44 +0000 (15:31 +0100)]
Update Windows shell integration rc copyright strings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
allexzander [Mon, 23 Jan 2023 13:24:35 +0000 (14:24 +0100)]
Merge pull request #5358 from nextcloud/bugfix/fix-bad-string-for-tr
Fix bad string for translation.
alex-z [Mon, 23 Jan 2023 12:05:55 +0000 (13:05 +0100)]
Fix bad string for translation.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Wed, 18 Jan 2023 11:21:18 +0000 (12:21 +0100)]
Merge pull request #5324 from nextcloud/bugfix/e2ee-vulnerability-random-initializationvectoor
Always generate random initialization vector when uploading encrypted file
alex-z [Wed, 11 Jan 2023 18:56:34 +0000 (19:56 +0100)]
Always generate random initialization vector when uploading encrypted file.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Wed, 18 Jan 2023 10:54:02 +0000 (11:54 +0100)]
Merge pull request #5323 from nextcloud/bugfix/e2ee-vulnerability-empty-metadatakeys
Bugfix/e2ee vulnerability empty metadatakeys
alex-z [Thu, 12 Jan 2023 10:15:34 +0000 (11:15 +0100)]
remove unrelated changes
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Thu, 12 Jan 2023 10:14:36 +0000 (11:14 +0100)]
remove unrelated changes
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 11 Jan 2023 18:46:01 +0000 (19:46 +0100)]
Fix memory leak.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 11 Jan 2023 17:25:01 +0000 (18:25 +0100)]
Fix security vulnerability when receiving empty metadataKeys from the server.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Tue, 17 Jan 2023 17:18:13 +0000 (18:18 +0100)]
Merge pull request #5329 from nextcloud/feature/allow-forceoverrideurl-via-command-line
Feature/allow forceoverrideurl via command line
alex-z [Fri, 13 Jan 2023 16:55:35 +0000 (17:55 +0100)]
Allow specifying the server force override URL and local sync folder path via command line.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Claudio Cambra [Fri, 6 Jan 2023 19:09:33 +0000 (20:09 +0100)]
Merge pull request #5279 from nextcloud/bugfix/fix-full-text-search-items
Fix full-text search results not being opened in browser
Claudio Cambra [Fri, 16 Dec 2022 14:28:31 +0000 (15:28 +0100)]
Extract makeResourceUrl lambda into separate static openableUrl method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 16 Dec 2022 14:25:09 +0000 (15:25 +0100)]
Simplify makeResourceUrl
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 16 Dec 2022 14:19:11 +0000 (15:19 +0100)]
Fix existing check and completion for relative resource URLs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 6 Jan 2023 17:43:08 +0000 (18:43 +0100)]
Merge pull request #5309 from Flowdalic/drop-qtquickcontrols1
Drop dependency on Qt Quick Controls 1
Florian Schmaus [Thu, 5 Jan 2023 10:58:08 +0000 (11:58 +0100)]
Drop dependency on Qt Quick Controls 1
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still
depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing
those imports will cause the QMl script to use the according API from
Quick Controls 2, which are, fortunately largely API-comptible.
This helps distribution to deprecate and remove Quick Controls 1 [2].
1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1
2: https://bugs.gentoo.org/889772
Signed-off-by: Florian Schmaus <flo@geekplace.eu>
Claudio Cambra [Fri, 6 Jan 2023 16:16:41 +0000 (17:16 +0100)]
Merge pull request #5299 from nextcloud/bugfix/macos-shellintegration-class-inits
Fix macOS shell integration class inits
Claudio Cambra [Wed, 28 Dec 2022 21:50:58 +0000 (22:50 +0100)]
Don't bother doing init procedure on FinderSync in macosx shell integration of invalid self
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Dec 2022 21:50:21 +0000 (22:50 +0100)]
Correctly init LineProcessor in macosx shell integration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 6 Jan 2023 14:28:04 +0000 (14:28 +0000)]
Fix(l10n): 🔠Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Mon, 2 Jan 2023 18:34:39 +0000 (19:34 +0100)]
Merge pull request #5272 from nextcloud/bugfix/fseventstreamscehdulerunloop-deprecation-fix
Replace now deprecated FSEventStreamScheduleWithRunLoop with FSEventStreamSetDispatchQueue
Claudio Cambra [Tue, 13 Dec 2022 12:40:57 +0000 (13:40 +0100)]
Replace now deprecated FSEventStreamScheduleWithRunLoop with FSEventStreamSetDispatchQueue
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 2 Jan 2023 17:05:29 +0000 (18:05 +0100)]
Merge pull request #5286 from nextcloud/bugfix/bad-qproperties
Fix warnings on QPROPERTY-s
Claudio Cambra [Mon, 19 Dec 2022 13:33:56 +0000 (14:33 +0100)]
Fix serverURL QPROPERTYes missing CONSTANT in theme class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 13:14:38 +0000 (14:14 +0100)]
Fix currentPage QPROPERTY missing NOTIFY in settingsdialog class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 13:00:12 +0000 (14:00 +0100)]
Fix interval QPROPERTY missing NOTIFY in slideshow class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Mon, 2 Jan 2023 12:12:17 +0000 (12:12 +0000)]
Fix(l10n): 🔠Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Fri, 30 Dec 2022 16:32:10 +0000 (17:32 +0100)]
Merge pull request #5293 from nextcloud/bugfix/do-not-generate-conflict-when-locking-and-unlocking
Update file's metadata in the local database when the etag changes while file remains unchanged. Fix subsequent conflict when locking and unlocking.
alex-z [Tue, 20 Dec 2022 18:49:35 +0000 (19:49 +0100)]
Update file's metadata in the local database when the etag changes while file remains unchanged. Fix subsequent conflict when locking and unlocking.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Fri, 30 Dec 2022 15:55:45 +0000 (16:55 +0100)]
Merge pull request #5296 from nextcloud/feature/authentication-via-apppassword-argument
Allow setting up an account with apppasword and folder via command-line arguments. For deployment.
alex-z [Fri, 30 Dec 2022 13:45:47 +0000 (14:45 +0100)]
Fix review comments from Claudio III.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Thu, 29 Dec 2022 17:28:28 +0000 (18:28 +0100)]
Fix review comments from Claudio II.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Thu, 29 Dec 2022 11:50:17 +0000 (12:50 +0100)]
Fix review comments from Claudio. Refactoring.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Fri, 23 Dec 2022 14:24:19 +0000 (15:24 +0100)]
Allow setting up an account with apppasword and folder via command-line arguments. For deployment.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Claudio Cambra [Fri, 30 Dec 2022 12:49:26 +0000 (13:49 +0100)]
Merge pull request #5298 from nextcloud/bugfix/windows-dark-palette
Improve backup dark mode palette for Windows
Claudio Cambra [Wed, 28 Dec 2022 16:18:04 +0000 (17:18 +0100)]
Improve backup dark mode palette for Windows
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
allexzander [Thu, 29 Dec 2022 16:59:42 +0000 (17:59 +0100)]
Merge pull request #5295 from nextcloud/feature/move-shellextensions-to-root-installdir
Feature/move shellextensions to root installdir
alex-z [Wed, 21 Dec 2022 11:20:46 +0000 (12:20 +0100)]
Move Windows shell extension DLLs to a root installation directory.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Claudio Cambra [Sat, 24 Dec 2022 12:48:04 +0000 (13:48 +0100)]
Merge pull request #5297 from nextcloud/Valdnet-patch-4
l10n: Remove space
Valdnet [Sat, 24 Dec 2022 11:56:08 +0000 (12:56 +0100)]
l10n: Remove space
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Claudio Cambra [Tue, 20 Dec 2022 18:16:20 +0000 (19:16 +0100)]
Merge pull request #5289 from nextcloud/bugfix/static-qregularexpressions
Declare all QRegularExpressions statically
Claudio Cambra [Mon, 19 Dec 2022 16:26:15 +0000 (17:26 +0100)]
Declare all QRegularExpressions statically
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 20 Dec 2022 12:43:40 +0000 (13:43 +0100)]
Merge pull request #5290 from nextcloud/bugfix/remove-unused
Remove unused variables
Claudio Cambra [Mon, 19 Dec 2022 16:38:35 +0000 (17:38 +0100)]
Remove unused targetFile QString in propagateremotemove
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:37:35 +0000 (17:37 +0100)]
Remove unused supportedTransmissionChecksums from bulkpropagatorjob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:35:42 +0000 (17:35 +0100)]
Remove unused QStrings from remotewipe
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:34:48 +0000 (17:34 +0100)]
Remove HACK for Windows Vista as this OS is no longer supported
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:33:20 +0000 (17:33 +0100)]
Remove unused variables in folderstatusdelegate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 20 Dec 2022 11:58:30 +0000 (12:58 +0100)]
Merge pull request #5287 from nextcloud/bugfix/corrext-signal-emit
Make correct use of Qt signal 'emit' keyword
Claudio Cambra [Mon, 19 Dec 2022 14:12:11 +0000 (15:12 +0100)]
Fix bad signal emissions
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 14:11:59 +0000 (15:11 +0100)]
Remove use of emit keyword where used for non signals
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 14:11:18 +0000 (15:11 +0100)]
Add 'emit' keyword to signal emissions that were missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 20 Dec 2022 11:07:09 +0000 (12:07 +0100)]
Merge pull request #5291 from nextcloud/bugfix/qfileinfo-exists
Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists
Claudio Cambra [Mon, 19 Dec 2022 16:46:27 +0000 (17:46 +0100)]
Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists, as it is faster
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Tue, 20 Dec 2022 03:35:32 +0000 (03:35 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 19 Dec 2022 03:37:57 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 18 Dec 2022 03:30:14 +0000 (03:30 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 17 Dec 2022 03:31:14 +0000 (03:31 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 16:40:30 +0000 (17:40 +0100)]
Merge pull request #5141 from nextcloud/bugfix/upgradeFromOldClients
fix migration from old settings configuration files
Claudio Cambra [Thu, 15 Dec 2022 15:09:39 +0000 (16:09 +0100)]
Fix conflicting definitions in anonymous namespace in Unity build
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 13:32:48 +0000 (14:32 +0100)]
Constify groups variable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 12:29:51 +0000 (13:29 +0100)]
Use std::make_unique rather than manually build unique_ptr for oCSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 12:27:12 +0000 (13:27 +0100)]
Make checks for config file more concise, warn when file not readable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 12:24:34 +0000 (13:24 +0100)]
Constify config file QFileInfo, create directly in if statement
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 7 Dec 2022 16:11:28 +0000 (17:11 +0100)]
Fix includes in accountmanager.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 6 Dec 2022 13:07:28 +0000 (14:07 +0100)]
Replace QDesktopServices datalocation with emulated version of it
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 1 Dec 2022 13:04:02 +0000 (14:04 +0100)]
Add full list of possible legacy config locations
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Mon, 7 Nov 2022 17:33:39 +0000 (18:33 +0100)]
fix migration from old settings configuration files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Thu, 15 Dec 2022 14:44:29 +0000 (15:44 +0100)]
Merge pull request #5258 from nextcloud/feature/do-not-sync-enc-folders-if-e2ee-is-not-setup
Feature/do not sync enc folders if e2ee is not setup
alex-z [Wed, 7 Dec 2022 18:43:27 +0000 (19:43 +0100)]
Do not sync encrypted folders if the E2EE mnemonic is not entered. Automatically blacklist them. Remove from blacklist once the E2EE mnemonic is provided.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Claudio Cambra [Thu, 15 Dec 2022 12:12:10 +0000 (13:12 +0100)]
Merge pull request #5245 from nextcloud/bugfix/remove-unused-headerbanner
Remove unused HeaderBanner component
Claudio Cambra [Wed, 7 Dec 2022 12:38:39 +0000 (13:38 +0100)]
Remove unused headerbanner component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 15 Dec 2022 11:02:00 +0000 (12:02 +0100)]
Merge pull request #5271 from nextcloud/feature/removeObsoleteNames
Feature/remove obsolete names
Matthieu Gallien [Tue, 13 Dec 2022 10:13:55 +0000 (11:13 +0100)]
use nextcloud.log suffix for log files of desktop client
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 13 Dec 2022 10:06:53 +0000 (11:06 +0100)]
use .nextcloudsync.log to perform file monitoring test at start
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 15 Dec 2022 10:10:58 +0000 (11:10 +0100)]
Merge pull request #5273 from nextcloud/bugfix/testsyncengine-fix-localstate-destroyed-failure
Fix SyncEngineTest failure when localstate is destroyed.
alex-z [Tue, 13 Dec 2022 13:41:07 +0000 (14:41 +0100)]
Fix SyncEngineTest failure when localstate is destroyed.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Matthieu Gallien [Thu, 15 Dec 2022 08:41:24 +0000 (09:41 +0100)]
Merge pull request #5269 from nextcloud/ci/forceCraftPixmanVersion
sets a fixed version for pixman when buildign desktop client via Craft
Matthieu Gallien [Tue, 13 Dec 2022 10:43:27 +0000 (11:43 +0100)]
tell OpenCppCoverage that we run an optimized build
should fix the crash accordign to the doc linked there
https://github.com/OpenCppCoverage/OpenCppCoverage/wiki/FAQ#your-application-has-thrown-an-unhandled-exception-code-
3221225477-exception_access_violation
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 13 Dec 2022 09:56:36 +0000 (10:56 +0100)]
sets a fixed version for pixman when buildign desktop client via Craft
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Thu, 15 Dec 2022 03:30:27 +0000 (03:30 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 14 Dec 2022 03:33:33 +0000 (03:33 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 20:32:11 +0000 (21:32 +0100)]
Merge pull request #5274 from nextcloud/bugfix/remove-get-task-allow-entitlement
Avoid the Get-Task-Allow Entitlement (macOS Notarization)
Claudio Cambra [Tue, 13 Dec 2022 18:53:53 +0000 (19:53 +0100)]
Avoid the Get-Task-Allow Entitlement (macOS Notarization)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 18:33:31 +0000 (19:33 +0100)]
Merge pull request #5131 from nextcloud/feature/implement-internal-link-share
Add an internal link share to the share dialog
Claudio Cambra [Tue, 13 Dec 2022 16:35:40 +0000 (17:35 +0100)]
Clean up data section for internal link in model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 16:34:41 +0000 (17:34 +0100)]
Fix copy link button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 16:34:23 +0000 (17:34 +0100)]
Remove unneeded property from ShareDetailsPage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 5 Nov 2022 12:20:13 +0000 (13:20 +0100)]
Fix bad remote path in sharetestutils fakefolder, which led to failed FakePropfindReply being provided in tests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 5 Nov 2022 12:19:37 +0000 (13:19 +0100)]
Incorporate internal link share into tests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 4 Nov 2022 18:30:22 +0000 (19:30 +0100)]
Add an internal link share to the share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
projects / nextcloud-desktop.git / log