Matthieu Gallien [Tue, 25 Oct 2022 09:04:20 +0000 (11:04 +0200)]
Merge pull request #5086 from nextcloud/NeroBurner-patch-1
Update CMake usage in README build instructions
NeroBurner [Sun, 23 Oct 2022 19:45:16 +0000 (21:45 +0200)]
Update CMake usage in README build instructions
CMake 3.14.0 released in March 2019 [1] added the command line config options
`-S <source-dir>` and `-B <build-dir>` and the build argument `--build <build-dir>` [2].
These options are universally valid independent of the build system used (`make`,
`nmake`, `ninja`, `MSBuild`,...), making the provided CMake commands more generic.
As reference Ubuntu 20.04 ships the CMake 3.16.3 [3] version.
- [1] https://gitlab.kitware.com/cmake/cmake/-/tags/v3.14.0
- [2] https://cmake.org/cmake/help/v3.14/release/3.14.html#command-line
- [3] https://packages.ubuntu.com/focal/cmake
Signed-off-by: NeroBurner <pyro4hell@gmail.com>
Nextcloud bot [Tue, 25 Oct 2022 03:24:49 +0000 (03:24 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 24 Oct 2022 16:36:17 +0000 (18:36 +0200)]
Merge pull request #5087 from nextcloud/bugfix/syncFolderStatusIcon
emit missing signal to update folder sync status icon
Matthieu Gallien [Mon, 24 Oct 2022 10:30:36 +0000 (12:30 +0200)]
emit missing signal to update folder sync status icon
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 24 Oct 2022 13:39:00 +0000 (15:39 +0200)]
Merge pull request #4949 from nextcloud/bugfix/checkCertAgainstPrivateKey
validate certificate for E2EE against private key
Matthieu Gallien [Wed, 12 Oct 2022 10:05:45 +0000 (12:05 +0200)]
fix review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 15:27:45 +0000 (17:27 +0200)]
fix more sonarcloud issues
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 13:43:56 +0000 (15:43 +0200)]
fix more issues reported by sonarcloud
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 13:41:31 +0000 (15:41 +0200)]
remove useless lines: fix review comment
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 09:21:29 +0000 (11:21 +0200)]
fix review comments from sonarcloud static analyzis
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 09:20:02 +0000 (11:20 +0200)]
address review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 16 Sep 2022 16:20:41 +0000 (18:20 +0200)]
validate certificate for E2EE against private key
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Mon, 24 Oct 2022 03:20:08 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 23 Oct 2022 03:20:11 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 22 Oct 2022 03:21:06 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 21 Oct 2022 03:28:29 +0000 (03:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 20 Oct 2022 13:18:26 +0000 (15:18 +0200)]
Merge pull request #5074 from nextcloud/bugfix/call-notification-buttons
Fix call notification dialog buttons
Claudio Cambra [Thu, 20 Oct 2022 12:11:10 +0000 (14:11 +0200)]
Fix call notification dialog buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
rakekniven [Thu, 20 Oct 2022 09:54:27 +0000 (11:54 +0200)]
Merge pull request #5066 from nextcloud/update/changelog
Update CHANGELOG with 3.6.1 changes.
Camila [Tue, 18 Oct 2022 14:15:15 +0000 (16:15 +0200)]
Update CHANGELOG with 3.6.1 changes.
Signed-off-by: Camila <hello@camila.codes>
Claudio Cambra [Wed, 19 Oct 2022 12:04:24 +0000 (14:04 +0200)]
Merge pull request #5013 from nextcloud/bugfix/webflow-user-strings
Improve "pretty user name"-related strings, display in webflow credentials
Claudio Cambra [Mon, 10 Oct 2022 10:56:51 +0000 (12:56 +0200)]
Change unchanging settings strings into constexpr auto in accountmanager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 6 Oct 2022 17:47:39 +0000 (19:47 +0200)]
Use prettyName more widely, instead of duplicating fallback string code
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 6 Oct 2022 17:45:24 +0000 (19:45 +0200)]
Display the user's 'pretty' name in the webflow credentials
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 6 Oct 2022 17:44:51 +0000 (19:44 +0200)]
Save account's display name in config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 6 Oct 2022 14:38:49 +0000 (16:38 +0200)]
Improve user-related strings in webflow credentials
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Wed, 19 Oct 2022 03:23:51 +0000 (03:23 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Tue, 18 Oct 2022 03:20:48 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Mon, 17 Oct 2022 11:56:38 +0000 (14:56 +0300)]
Merge pull request #5040 from nextcloud/bugfix/local-editing-fix-account-not-found
Fix account not found when doing local file editing.
alex-z [Thu, 13 Oct 2022 08:24:16 +0000 (11:24 +0300)]
Fix account not found when doing local file editing.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Camila [Mon, 17 Oct 2022 11:42:42 +0000 (13:42 +0200)]
Merge pull request #4989 from nextcloud/bugfix/dismiss
Fix the dismiss button: display it whenever possible.
Camila [Fri, 30 Sep 2022 13:45:53 +0000 (15:45 +0200)]
Update tests.
Signed-off-by: Camila <hello@camila.codes>
Camila [Fri, 30 Sep 2022 12:31:24 +0000 (14:31 +0200)]
The dismiss button is now a CustomButton component.
Signed-off-by: Camila <hello@camila.codes>
Camila [Thu, 29 Sep 2022 19:26:20 +0000 (21:26 +0200)]
Fix the dismiss button: display it whenever possible.
Signed-off-by: Camila <hello@camila.codes>
Matthieu Gallien [Mon, 17 Oct 2022 09:13:03 +0000 (11:13 +0200)]
Merge pull request #5039 from nextcloud/bugfix/checkTokenForEditLocallyRequests
Bugfix/check token for edit locally requests
Matthieu Gallien [Wed, 12 Oct 2022 16:01:15 +0000 (18:01 +0200)]
edit locally requires a valid token
check on server that the token received during a request to open a local
file is indeed a valid one
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 13 Oct 2022 10:14:22 +0000 (12:14 +0200)]
makes JsonApiJob share common code with SimpleApiJob
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 12 Oct 2022 16:02:26 +0000 (18:02 +0200)]
introduce a very simple network job to do API requests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Mon, 17 Oct 2022 03:19:31 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 16 Oct 2022 03:19:17 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 15 Oct 2022 03:19:24 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 14 Oct 2022 03:23:55 +0000 (03:23 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Wed, 12 Oct 2022 11:43:33 +0000 (13:43 +0200)]
Merge pull request #4979 from nextcloud/bugfix/fixVersionComparisonsOnWindows
use correct version copmparison on NSIS updater: fix update from rc
Matthieu Gallien [Wed, 28 Sep 2022 09:41:23 +0000 (11:41 +0200)]
fix review comments
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 27 Sep 2022 16:55:29 +0000 (18:55 +0200)]
use correct version copmparison on NSIS updater: fix update from rc
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 28 Sep 2022 09:37:37 +0000 (11:37 +0200)]
remove support for skipping an update: hard to understand for users
skiping an update is probably there for historical reasons to work
around broken updates in the past
this can lead to users not getting an update they should be getting
this can elad to user confusion and the current user interaction is
broken if you do not go read the settings file with a text editor
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Wed, 12 Oct 2022 10:00:10 +0000 (12:00 +0200)]
Merge pull request #5012 from nextcloud/bugfix/offline-user-status
Fix invisible user status selector button not being checked when user is in Offline mode
Claudio Cambra [Wed, 5 Oct 2022 19:44:02 +0000 (21:44 +0200)]
Fix invisible user status selector button not being checked when user is in Offline mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Matthieu Gallien [Wed, 12 Oct 2022 07:48:34 +0000 (09:48 +0200)]
Merge pull request #5032 from nextcloud/bugfix/improveSyncLogs
improve logs when adding sync errors in activity list of main dialog
Matthieu Gallien [Tue, 11 Oct 2022 13:59:45 +0000 (15:59 +0200)]
improve logs when adding sync errors in activity list of main dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Wed, 12 Oct 2022 03:19:04 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Tue, 11 Oct 2022 21:48:09 +0000 (23:48 +0200)]
Merge pull request #4998 from nextcloud/ci/removeOneWarningOnWindows
do not ignore return value
Matthieu Gallien [Sun, 2 Oct 2022 09:31:50 +0000 (11:31 +0200)]
do not ignore return value
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 11 Oct 2022 19:54:17 +0000 (21:54 +0200)]
Merge pull request #5024 from nextcloud/bugfix/filesLockFailMetadata
Bugfix/files lock fail metadata
Matthieu Gallien [Fri, 7 Oct 2022 16:54:19 +0000 (18:54 +0200)]
ensure we do not loose data when syncing locked files
fixes #5014
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 7 Oct 2022 16:21:41 +0000 (18:21 +0200)]
add extra tests for lock files to better capture desired behavior
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 7 Oct 2022 16:15:13 +0000 (18:15 +0200)]
test that files soon to be expired will be synced automatically
try to ensure that we properly sync again files for which lock has
expired
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Tue, 11 Oct 2022 11:15:31 +0000 (14:15 +0300)]
Merge pull request #5022 from nextcloud/bugfix/cmdclient-do-not-trust-certs-by-default
Command-line client. Do not trust SSL certificates by default, unless '--trust' option is set.
alex-z [Mon, 10 Oct 2022 14:05:44 +0000 (17:05 +0300)]
Fix error in logic.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Fri, 7 Oct 2022 15:09:10 +0000 (18:09 +0300)]
Command-line client. Do not trust SSL certificates by default, unlss '--trust' option is set.
Signed-off-by: allexzander <blackslayer4@gmail.com>
Nextcloud bot [Tue, 11 Oct 2022 03:17:10 +0000 (03:17 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Mon, 10 Oct 2022 14:57:27 +0000 (17:57 +0300)]
Merge pull request #4990 from nextcloud/bugfix/local-editing-sync-and-loading-indicator
Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.
alex-z [Wed, 28 Sep 2022 11:26:57 +0000 (14:26 +0300)]
Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.'
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Mon, 10 Oct 2022 03:23:59 +0000 (03:23 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 9 Oct 2022 03:34:50 +0000 (03:34 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 7 Oct 2022 13:36:55 +0000 (13:36 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Tobias Kaminsky [Fri, 7 Oct 2022 13:26:33 +0000 (15:26 +0200)]
Merge pull request #5019 from nextcloud/transifexUpdate
Update after tx migrate
tobiasKaminsky [Fri, 7 Oct 2022 13:23:56 +0000 (15:23 +0200)]
Update after tx migrate
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
allexzander [Tue, 4 Oct 2022 19:40:15 +0000 (22:40 +0300)]
Merge pull request #4942 from nextcloud/feature/vfs-windows-sharing-and-lock-state
Feature/vfs windows sharing and lock state
allexzander [Fri, 2 Sep 2022 09:48:52 +0000 (12:48 +0300)]
VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer
Signed-off-by: allexzander <blackslayer4@gmail.com>
Matthieu Gallien [Tue, 4 Oct 2022 16:32:07 +0000 (18:32 +0200)]
Merge pull request #4991 from nextcloud/ci/checkFormatWithClangFormat
let's check the format via some github action
Matthieu Gallien [Tue, 4 Oct 2022 12:02:47 +0000 (14:02 +0200)]
only test format on changed files and changed lines
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 4 Oct 2022 11:37:16 +0000 (13:37 +0200)]
pick up clang-format conf files from KDE community
takes it from current extra-cmake-modules repository
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 30 Sep 2022 14:43:23 +0000 (16:43 +0200)]
let's check the format via some github action
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Camila [Tue, 4 Oct 2022 13:35:16 +0000 (15:35 +0200)]
Merge pull request #5002 from nextcloud/update-client-image
Update client image
Camila [Mon, 3 Oct 2022 14:59:14 +0000 (16:59 +0200)]
Remove clang-tidy from .drone.yml.
It is being replaced by GH actions.
Signed-off-by: Camila <hello@camila.codes>
Camila [Mon, 3 Oct 2022 14:57:50 +0000 (16:57 +0200)]
Update to docker image to client-5.15-11.
Signed-off-by: Camila <hello@camila.codes>
Claudio Cambra [Tue, 4 Oct 2022 10:58:34 +0000 (12:58 +0200)]
Merge pull request #4962 from nextcloud/bugfix/files-not-unlocking
Claudio Cambra [Mon, 3 Oct 2022 15:22:36 +0000 (17:22 +0200)]
Ensure we are checking lock state without affecting sync behaviour
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Wed, 21 Sep 2022 11:06:16 +0000 (13:06 +0200)]
Check local file locked and unlocked correctly in testlocaldiscovery
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Sat, 24 Sep 2022 01:00:54 +0000 (03:00 +0200)]
Unschedule previously scheduled sync runs for locked files if it is found the sync run is no longer needed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Fri, 23 Sep 2022 00:33:15 +0000 (02:33 +0200)]
More efficiently schedule sync runs for files that need delayed sync runs
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Tue, 20 Sep 2022 21:03:39 +0000 (23:03 +0200)]
Fix files not unlocking after lock time expired
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Matthieu Gallien [Tue, 4 Oct 2022 09:44:46 +0000 (11:44 +0200)]
Merge pull request #4992 from nextcloud/ci/useNoDiscard
Ci/use no discard
Matthieu Gallien [Fri, 30 Sep 2022 17:12:08 +0000 (19:12 +0200)]
add [[nodiscard]] attribute via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 30 Sep 2022 17:19:03 +0000 (19:19 +0200)]
fix [[nodiscard]] single warning
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 4 Oct 2022 09:14:27 +0000 (11:14 +0200)]
Merge pull request #4993 from nextcloud/ci/useUsing
apply modernize-use-using via clang-tidy
Matthieu Gallien [Fri, 30 Sep 2022 17:56:31 +0000 (19:56 +0200)]
apply modernize-use-using via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-using' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Mon, 3 Oct 2022 23:13:20 +0000 (01:13 +0200)]
Merge pull request #4982 from nextcloud/bugfix/enforced-max-expire-date-link-share-fix
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
Claudio Cambra [Wed, 28 Sep 2022 10:26:37 +0000 (12:26 +0200)]
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Matthieu Gallien [Mon, 3 Oct 2022 20:01:51 +0000 (22:01 +0200)]
Merge pull request #5004 from nextcloud/configure-clang-tidy-checks
configure a list of checks for clang-tidy
Matthieu Gallien [Mon, 3 Oct 2022 19:05:50 +0000 (21:05 +0200)]
configure a list of checks for clang-tidy
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 3 Oct 2022 18:53:22 +0000 (20:53 +0200)]
Merge pull request #5003 from nextcloud/update-client-appimage-image
switch AppImage CI to latest tag: client-appimage-6
Matthieu Gallien [Mon, 3 Oct 2022 15:22:02 +0000 (17:22 +0200)]
switch AppImage CI to latest tag: client-appimage-6
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 3 Oct 2022 11:50:22 +0000 (13:50 +0200)]
Merge pull request #4994 from nextcloud/ci/cppcoreguidelines-pro-type-static-cast-downcast
avoid possibly crashing static_cast
Matthieu Gallien [Fri, 30 Sep 2022 19:36:58 +0000 (21:36 +0200)]
avoid possibly crashing static_cast
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix
this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 3 Oct 2022 08:22:45 +0000 (10:22 +0200)]
Merge pull request #4996 from nextcloud/cleanConfigFileConstants
alway use constexpr for all text constants
Matthieu Gallien [Sun, 2 Oct 2022 13:48:20 +0000 (15:48 +0200)]
Merge branch 'master' into cleanConfigFileConstants
Matthieu Gallien [Sun, 2 Oct 2022 13:48:07 +0000 (15:48 +0200)]
Merge pull request #4999 from nextcloud/ci/checkClangTidyInCi
check our code with clang-tidy
projects / nextcloud-desktop.git / log