From: Matthias Clasen <mclasen@redhat.com>
Date: Wed, 8 Mar 2023 18:06:53 +0000 (-0500)
Subject: widget: Simplify size allocation
X-Git-Tag: archive/raspbian/4.12.3+ds-1+rpi1~1^2^2^2~22^2~5^2~35^2~4
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=ffb7177c2e39f97f79fe2e1c7f770c4046234d5e;p=gtk4.git

widget: Simplify size allocation

Don't call ensure_allocate if we've just
done size_allocate. This makes criticals
from reshowing popovers go away.
---

diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c
index fd242a88eb..274b507b7c 100644
--- a/gtk/gtkwidget.c
+++ b/gtk/gtkwidget.c
@@ -4037,7 +4037,10 @@ gtk_widget_allocate (GtkWidget    *widget,
   size_changed = (priv->width != adjusted.width) || (priv->height != adjusted.height);
 
   if (!alloc_needed && !size_changed && !baseline_changed)
-    goto skip_allocate;
+    {
+      gtk_widget_ensure_allocate (widget);
+      goto skip_allocate;
+    }
 
   priv->width = adjusted.width;
   priv->height = adjusted.height;
@@ -4085,9 +4088,6 @@ skip_allocate:
     gtk_widget_queue_draw (priv->parent);
 
 out:
-  if (priv->alloc_needed_on_child)
-    gtk_widget_ensure_allocate (widget);
-
   gtk_widget_pop_verify_invariants (widget);
 }