From: Christian Kamm <mail@ckamm.de>
Date: Wed, 23 Jan 2019 11:58:14 +0000 (+0100)
Subject: Vfs: Clarify SyncEngine::wipeVirtualFiles()
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~21^2~468^2~310
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f89450648f6fac5f2ef20f18dee40b64ef6d88ac;p=nextcloud-desktop.git

Vfs: Clarify SyncEngine::wipeVirtualFiles()

Possibly the behavior should actually change and the function should
de-placeholder all items, not just dehydrated ones.
---

diff --git a/src/libsync/syncengine.cpp b/src/libsync/syncengine.cpp
index 29ddcf6fd..c48b75a56 100644
--- a/src/libsync/syncengine.cpp
+++ b/src/libsync/syncengine.cpp
@@ -1044,7 +1044,8 @@ void SyncEngine::wipeVirtualFiles(const QString &localPath, SyncJournalDb &journ
 
     journal.forceRemoteDiscoveryNextSync();
 
-    // Postcondition: No ItemTypeVirtualFile / ItemTypeVirtualFileDownload left in the db
+    // Postcondition: No ItemTypeVirtualFile / ItemTypeVirtualFileDownload left in the db.
+    // But hydrated placeholders may still be around.
 }
 
 void SyncEngine::abort()
diff --git a/src/libsync/syncengine.h b/src/libsync/syncengine.h
index 9434ab5ac..add14d48e 100644
--- a/src/libsync/syncengine.h
+++ b/src/libsync/syncengine.h
@@ -128,6 +128,9 @@ public:
      *
      * Particularly useful when switching off vfs mode or switching to a
      * different kind of vfs.
+     *
+     * Note that *hydrated* placeholder files might still be left. These will
+     * get cleaned up by Vfs::unregisterFolder().
      */
     static void wipeVirtualFiles(const QString &localPath, SyncJournalDb &journal, Vfs &vfs);