From: Sian Cao <yinshuiboy@gmail.com>
Date: Fri, 8 Dec 2017 06:47:32 +0000 (+0800)
Subject: fix: break forever loop for syncing backend data
X-Git-Tag: archive/raspbian/5.7.12-2+rpi1^2~144^2~3
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f70e500ec2fd5c751e40833bdc4df586614bcff2;p=dtkcore.git

fix: break forever loop for syncing backend data

option setValue emits valueChanged, and handler for valueChanged emits
setOption which requests backend to do doSetOption asynchronously which
in turn calls option's setValue again.

Change-Id: I5a6b5ccabfd29b26d3079779aad80461d7866d47
---

diff --git a/src/settings/backend/qsettingbackend.cpp b/src/settings/backend/qsettingbackend.cpp
index fec9e4b..ae15b4f 100644
--- a/src/settings/backend/qsettingbackend.cpp
+++ b/src/settings/backend/qsettingbackend.cpp
@@ -72,7 +72,6 @@ void QSettingBackend::doSetOption(const QString &key, const QVariant &value)
     auto oldValue = d->settings->value("value");
     if (oldValue != value) {
         d->settings->setValue("value", value);
-        Q_EMIT optionChanged(key, value);
     }
     d->settings->endGroup();
     d->settings->sync();