From: Olivier Goffart <ogoffart@woboq.com>
Date: Fri, 28 Jul 2017 08:13:07 +0000 (+0200)
Subject: FolderWizard: fix crash in FolderWizardRemotePath::slotHandleLsColNetworkError
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~704^2^2~10
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f707a43b3cff0491ac5b0428d0e18a3aa3fa2db3;p=nextcloud-desktop.git

FolderWizard: fix crash in FolderWizardRemotePath::slotHandleLsColNetworkError

The Job is a LsColJob, not a MkColJob!

Reproduce by entering a name with invalid character that cause an error 400
in the folder wizard's remote path line edit.

(Relates issue #5924)
---

diff --git a/src/gui/folderwizard.cpp b/src/gui/folderwizard.cpp
index 940cf8b3a..168f60d88 100644
--- a/src/gui/folderwizard.cpp
+++ b/src/gui/folderwizard.cpp
@@ -22,6 +22,7 @@
 #include "accountstate.h"
 #include "creds/abstractcredentials.h"
 #include "wizard/owncloudwizard.h"
+#include "asserts.h"
 
 #include <QDesktopServices>
 #include <QDir>
@@ -229,7 +230,8 @@ void FolderWizardRemotePath::slotHandleMkdirNetworkError(QNetworkReply *reply)
 
 void FolderWizardRemotePath::slotHandleLsColNetworkError(QNetworkReply * /*reply*/)
 {
-    auto job = qobject_cast<MkColJob *>(sender());
+    auto job = qobject_cast<LsColJob *>(sender());
+    ASSERT(job);
     showWarn(tr("Failed to list a folder. Error: %1")
                  .arg(job->errorStringParsingBody()));
 }