From: Colin Walters <walters@verbum.org>
Date: Tue, 29 Nov 2016 02:12:53 +0000 (-0500)
Subject: cmdline: Fix minor leak in delta cmdline entrypoint
X-Git-Tag: archive/raspbian/2017.12-1+rpi1~1^2^2^2^2^2^2^2^2^2~8
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f6103ed41d72445e011acf40a1a26f99488ff244;p=ostree.git

cmdline: Fix minor leak in delta cmdline entrypoint

Small, but it's important to stay clean.

Closes: #598
Approved by: jlebon

Gbp-Pq: Name ASAN-cmdline-Fix-minor-leak-in-delta-cmdline-entrypoint.patch
---

diff --git a/src/ostree/ot-builtin-static-delta.c b/src/ostree/ot-builtin-static-delta.c
index ca29911a..e1c3bb48 100644
--- a/src/ostree/ot-builtin-static-delta.c
+++ b/src/ostree/ot-builtin-static-delta.c
@@ -336,11 +336,13 @@ ot_static_delta_builtin_generate (int argc, char **argv, GCancellable *cancellab
       g_print ("Generating static delta:\n");
       g_print ("  From: %s\n", from_resolved ? from_resolved : "empty");
       g_print ("  To:   %s\n", to_resolved);
-      if (!ostree_repo_static_delta_generate (repo, OSTREE_STATIC_DELTA_GENERATE_OPT_MAJOR,
-                                              from_resolved, to_resolved, NULL,
-                                              g_variant_builder_end (parambuilder),
-                                              cancellable, error))
-        goto out;
+      { g_autoptr(GVariant) params = g_variant_ref_sink (g_variant_builder_end (parambuilder));
+        if (!ostree_repo_static_delta_generate (repo, OSTREE_STATIC_DELTA_GENERATE_OPT_MAJOR,
+                                                from_resolved, to_resolved, NULL,
+                                                params,
+                                                cancellable, error))
+          goto out;
+      }
 
     }