From: Matthias Clasen <mclasen@redhat.com>
Date: Sun, 3 Apr 2022 12:04:35 +0000 (-0400)
Subject: css: Plug a memory leak
X-Git-Tag: archive/raspbian/4.8.3+ds-2+rpi1~3^2~20^2~4^2~268^2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f57eec5288c3f83e8e8eba68f07aea49f01073a0;p=gtk4.git

css: Plug a memory leak

We were leaking the terms of calc values. Oops.
---

diff --git a/gtk/gtkcssnumbervalue.c b/gtk/gtkcssnumbervalue.c
index 7b2dbeacc9..78e11b86ee 100644
--- a/gtk/gtkcssnumbervalue.c
+++ b/gtk/gtkcssnumbervalue.c
@@ -69,11 +69,18 @@ gtk_css_calc_value_new_from_array (GtkCssValue **values,
   return result;
 }
 
-
 static void
-gtk_css_value_number_free (GtkCssValue *value)
+gtk_css_value_number_free (GtkCssValue *number)
 {
-  g_slice_free (GtkCssValue, value);
+  if (number->type == TYPE_CALC)
+    {
+      const guint n_terms = number->calc.n_terms;
+
+      for (guint i = 0; i < n_terms; i++)
+        _gtk_css_value_unref (number->calc.terms[i]);
+    }
+
+  g_slice_free (GtkCssValue, number);
 }
 
 static double