From: Boris Ostrovsky Date: Wed, 28 Sep 2016 13:22:04 +0000 (-0400) Subject: libxl: Initialize domain build info before calling libxl__domain_make X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~282 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f14e5cda422f2413d7e739dc0caf5d5cb6a061be;p=xen.git libxl: Initialize domain build info before calling libxl__domain_make libxl__domain_make() may want to use b_info so we should set defaults a little earlier. Signed-off-by: Boris Ostrovsky Acked-by: Wei Liu --- diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 04f8ae987c..07b2b4b243 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -899,17 +899,6 @@ static void initiate_domain_create(libxl__egc *egc, goto error_out; } - ret = libxl__domain_make(gc, d_config, &domid, &state->config); - if (ret) { - LOG(ERROR, "cannot make domain: %d", ret); - dcs->guest_domid = domid; - ret = ERROR_FAIL; - goto error_out; - } - - dcs->guest_domid = domid; - dcs->sdss.dm.guest_domid = 0; /* means we haven't spawned */ - ret = libxl__domain_build_info_setdefault(gc, &d_config->b_info); if (ret) { LOG(ERROR, "Unable to set domain build info defaults"); @@ -923,6 +912,17 @@ static void initiate_domain_create(libxl__egc *egc, goto error_out; } + ret = libxl__domain_make(gc, d_config, &domid, &state->config); + if (ret) { + LOG(ERROR, "cannot make domain: %d", ret); + dcs->guest_domid = domid; + ret = ERROR_FAIL; + goto error_out; + } + + dcs->guest_domid = domid; + dcs->sdss.dm.guest_domid = 0; /* means we haven't spawned */ + /* * Set the dm version quite early so that libxl doesn't have to pass the * build info around just to know if the domain has a device model or not.