From: Julien Grall <jgrall@amazon.com>
Date: Wed, 23 Feb 2022 18:38:31 +0000 (+0000)
Subject: xen/mm: Remove always true ASSERT() in free_heap_pages()
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~910
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f1097988b9baeb4cae38a1a71e027794291213ff;p=xen.git

xen/mm: Remove always true ASSERT() in free_heap_pages()

free_heap_pages() has an ASSERT() checking that node is >= 0. However
node is defined as an unsigned int. So it cannot be negative.

Therefore remove the check as it will always be true.

Coverity-ID: 1055631
Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com><mailto:andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 4635718237..e971bf91e0 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1441,7 +1441,6 @@ static void free_heap_pages(
     unsigned int zone = page_to_zone(pg);
 
     ASSERT(order <= MAX_ORDER);
-    ASSERT(node >= 0);
 
     spin_lock(&heap_lock);