From: Wei Liu Date: Wed, 13 Sep 2017 15:24:15 +0000 (+0100) Subject: x86/mm: move {un,}adjust_guest_l*e to pv/mm.h X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~1355 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=f04bc26dd534cc7309429ec3f9346a4087d93b49;p=xen.git x86/mm: move {un,}adjust_guest_l*e to pv/mm.h Signed-off-by: Wei Liu Acked-by: Jan Beulich --- diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index f5a129d77f..7fbcea98a2 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1176,63 +1176,6 @@ get_page_from_l4e( return rc; } -static l1_pgentry_t adjust_guest_l1e(l1_pgentry_t l1e, const struct domain *d) -{ - if ( likely(l1e_get_flags(l1e) & _PAGE_PRESENT) && - likely(!is_pv_32bit_domain(d)) ) - { - /* _PAGE_GUEST_KERNEL page cannot have the Global bit set. */ - if ( (l1e_get_flags(l1e) & (_PAGE_GUEST_KERNEL | _PAGE_GLOBAL)) == - (_PAGE_GUEST_KERNEL | _PAGE_GLOBAL) ) - gdprintk(XENLOG_WARNING, "Global bit is set in kernel page %lx\n", - l1e_get_pfn(l1e)); - - if ( !(l1e_get_flags(l1e) & _PAGE_USER) ) - l1e_add_flags(l1e, (_PAGE_GUEST_KERNEL | _PAGE_USER)); - - if ( !(l1e_get_flags(l1e) & _PAGE_GUEST_KERNEL) ) - l1e_add_flags(l1e, (_PAGE_GLOBAL | _PAGE_USER)); - } - - return l1e; -} - -static l2_pgentry_t adjust_guest_l2e(l2_pgentry_t l2e, const struct domain *d) -{ - if ( likely(l2e_get_flags(l2e) & _PAGE_PRESENT) && - likely(!is_pv_32bit_domain(d)) ) - l2e_add_flags(l2e, _PAGE_USER); - - return l2e; -} - -static l3_pgentry_t adjust_guest_l3e(l3_pgentry_t l3e, const struct domain *d) -{ - if ( likely(l3e_get_flags(l3e) & _PAGE_PRESENT) ) - l3e_add_flags(l3e, (likely(!is_pv_32bit_domain(d)) - ? _PAGE_USER : _PAGE_USER | _PAGE_RW)); - - return l3e; -} - -static l3_pgentry_t unadjust_guest_l3e(l3_pgentry_t l3e, const struct domain *d) -{ - if ( unlikely(is_pv_32bit_domain(d)) && - likely(l3e_get_flags(l3e) & _PAGE_PRESENT) ) - l3e_remove_flags(l3e, _PAGE_USER | _PAGE_RW | _PAGE_ACCESSED); - - return l3e; -} - -static l4_pgentry_t adjust_guest_l4e(l4_pgentry_t l4e, const struct domain *d) -{ - if ( likely(l4e_get_flags(l4e) & _PAGE_PRESENT) && - likely(!is_pv_32bit_domain(d)) ) - l4e_add_flags(l4e, _PAGE_USER); - - return l4e; -} - void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner) { unsigned long pfn = l1e_get_pfn(l1e); diff --git a/xen/arch/x86/pv/mm.h b/xen/arch/x86/pv/mm.h index bdf18931f1..ba4deee872 100644 --- a/xen/arch/x86/pv/mm.h +++ b/xen/arch/x86/pv/mm.h @@ -85,4 +85,66 @@ static inline bool update_intpte(intpte_t *p, intpte_t old, intpte_t new, _t ## e_get_intpte(_o), _t ## e_get_intpte(_n), \ (_m), (_v), (_ad)) +static inline l1_pgentry_t adjust_guest_l1e(l1_pgentry_t l1e, + const struct domain *d) +{ + if ( likely(l1e_get_flags(l1e) & _PAGE_PRESENT) && + likely(!is_pv_32bit_domain(d)) ) + { + /* _PAGE_GUEST_KERNEL page cannot have the Global bit set. */ + if ( (l1e_get_flags(l1e) & (_PAGE_GUEST_KERNEL | _PAGE_GLOBAL)) == + (_PAGE_GUEST_KERNEL | _PAGE_GLOBAL) ) + gdprintk(XENLOG_WARNING, "Global bit is set in kernel page %lx\n", + l1e_get_pfn(l1e)); + + if ( !(l1e_get_flags(l1e) & _PAGE_USER) ) + l1e_add_flags(l1e, (_PAGE_GUEST_KERNEL | _PAGE_USER)); + + if ( !(l1e_get_flags(l1e) & _PAGE_GUEST_KERNEL) ) + l1e_add_flags(l1e, (_PAGE_GLOBAL | _PAGE_USER)); + } + + return l1e; +} + +static inline l2_pgentry_t adjust_guest_l2e(l2_pgentry_t l2e, + const struct domain *d) +{ + if ( likely(l2e_get_flags(l2e) & _PAGE_PRESENT) && + likely(!is_pv_32bit_domain(d)) ) + l2e_add_flags(l2e, _PAGE_USER); + + return l2e; +} + +static inline l3_pgentry_t adjust_guest_l3e(l3_pgentry_t l3e, + const struct domain *d) +{ + if ( likely(l3e_get_flags(l3e) & _PAGE_PRESENT) ) + l3e_add_flags(l3e, (likely(!is_pv_32bit_domain(d)) + ? _PAGE_USER : _PAGE_USER | _PAGE_RW)); + + return l3e; +} + +static inline l3_pgentry_t unadjust_guest_l3e(l3_pgentry_t l3e, + const struct domain *d) +{ + if ( unlikely(is_pv_32bit_domain(d)) && + likely(l3e_get_flags(l3e) & _PAGE_PRESENT) ) + l3e_remove_flags(l3e, _PAGE_USER | _PAGE_RW | _PAGE_ACCESSED); + + return l3e; +} + +static inline l4_pgentry_t adjust_guest_l4e(l4_pgentry_t l4e, + const struct domain *d) +{ + if ( likely(l4e_get_flags(l4e) & _PAGE_PRESENT) && + likely(!is_pv_32bit_domain(d)) ) + l4e_add_flags(l4e, _PAGE_USER); + + return l4e; +} + #endif /* __PV_MM_H__ */