From: Max Kellermann Date: Mon, 21 Feb 2022 10:03:13 +0000 (+0100) Subject: lib/iov_iter: initialize "flags" in new pipe_buffer X-Git-Tag: archive/raspbian/5.10.92-2+rpi1^2~24 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=edb5667f3e11fbcf2f32ea0bdab1b90e94e7034f;p=linux.git lib/iov_iter: initialize "flags" in new pipe_buffer Origin: https://git.kernel.org/linus/9d2231c5d74e13b2a0546fee6737ee4446017903 The functions copy_page_to_iter_pipe() and push_pipe() can both allocate a new pipe_buffer, but the "flags" member initializer is missing. Fixes: 241699cd72a8 ("new iov_iter flavour: pipe-backed") To: Alexander Viro To: linux-fsdevel@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Max Kellermann Signed-off-by: Al Viro Gbp-Pq: Topic bugfix/all Gbp-Pq: Name lib-iov_iter-initialize-flags-in-new-pipe_buffer.patch --- diff --git a/lib/iov_iter.c b/lib/iov_iter.c index b364231b5fc..1b0a349fbcd 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c @@ -407,6 +407,7 @@ static size_t copy_page_to_iter_pipe(struct page *page, size_t offset, size_t by return 0; buf->ops = &page_cache_pipe_buf_ops; + buf->flags = 0; get_page(page); buf->page = page; buf->offset = offset; @@ -543,6 +544,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size, break; buf->ops = &default_pipe_buf_ops; + buf->flags = 0; buf->page = page; buf->offset = 0; buf->len = min_t(ssize_t, left, PAGE_SIZE);