From: Olivier Goffart <ogoffart@woboq.com>
Date: Tue, 7 Aug 2018 07:50:55 +0000 (+0200)
Subject: MSI: Fix crash in the auto updater
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~22^2~46^2~16
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=e93972824daf18f6d8fff897cd3ca3fd5984685f;p=nextcloud-desktop.git

MSI: Fix crash in the auto updater

'auto' here is a QStringBuilder referencing a temporary

Ammend commit 150d4f5935c9480cae0a84506af4efa940b64095
(MSI: Always with logfile #6609)

Found in the crash reporter:
https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/
---

diff --git a/src/gui/updater/ocupdater.cpp b/src/gui/updater/ocupdater.cpp
index 62514a5ce..b55e73ee5 100644
--- a/src/gui/updater/ocupdater.cpp
+++ b/src/gui/updater/ocupdater.cpp
@@ -208,7 +208,7 @@ void OCUpdater::slotStartInstaller()
             return QDir::toNativeSeparators(path);
         };
 
-        auto msiLogFile = cfg.configPath() + "msi.log";
+        QString msiLogFile = cfg.configPath() + "msi.log";
         QString command = QString("&{msiexec /norestart /passive /i '%1' /L*V '%2'| Out-Null ; &'%3'}")
              .arg(preparePathForPowershell(updateFile))
              .arg(preparePathForPowershell(msiLogFile))