From: Cosimo Cecchi <cosimoc@gnome.org>
Date: Thu, 7 Jun 2012 20:01:02 +0000 (-0400)
Subject: liststore: fix transformation of GValues on set
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~24^2~19773
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=e92e767246bae9c30db4649656bf1c90bd6be8b4;p=gtk4.git

liststore: fix transformation of GValues on set

There are three bugs here:
- we should check if the value type is transformable instead of being
  compatible, since that's all we care about in order to call
  g_value_transform()
- the check is only meaningful in the direction
  passed-in-type->column-type and not viceversa
- we should init the destination GValue to the column type before
  calling g_value_transform on it, or the destination type information
  will be missing and the method will fail

Thanks to Jasper St. Pierre and Colin Walters for all the help in
tracking this down.

https://bugzilla.gnome.org/show_bug.cgi?id=677649
---

diff --git a/gtk/gtkliststore.c b/gtk/gtkliststore.c
index 763d1e1f8c..2d99d5f36c 100644
--- a/gtk/gtkliststore.c
+++ b/gtk/gtkliststore.c
@@ -842,8 +842,7 @@ gtk_list_store_real_set_value (GtkListStore *list_store,
 
   if (! g_type_is_a (G_VALUE_TYPE (value), priv->column_headers[column]))
     {
-      if (! (g_value_type_compatible (G_VALUE_TYPE (value), priv->column_headers[column]) &&
-	     g_value_type_compatible (priv->column_headers[column], G_VALUE_TYPE (value))))
+      if (! (g_value_type_transformable (G_VALUE_TYPE (value), priv->column_headers[column])))
 	{
 	  g_warning ("%s: Unable to convert from %s to %s\n",
 		     G_STRLOC,
@@ -851,6 +850,8 @@ gtk_list_store_real_set_value (GtkListStore *list_store,
 		     g_type_name (priv->column_headers[column]));
 	  return retval;
 	}
+
+      g_value_init (&real_value, priv->column_headers[column]);
       if (!g_value_transform (value, &real_value))
 	{
 	  g_warning ("%s: Unable to make conversion from %s to %s\n",