From: Julien Grall Date: Thu, 24 Jun 2021 14:55:03 +0000 (+0100) Subject: tools/xenstored: Remove redundant check in socket_can_process() X-Git-Tag: archive/raspbian/4.16.0+51-g0941d6cb-1+rpi1~2^2~42^2~389 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=e87d8f60fa9b6eaa6a2357545a96e4fff05dbef0;p=xen.git tools/xenstored: Remove redundant check in socket_can_process() Commit 3adfb50315d9 ("tools/xenstored: Introduce a wrapper for conn->funcs->can_{read, write}") consolidated the check !conn->is_ignored in two new wrappers. This means the check in socket_can_process() is now redundant. In fact it should have been removed in orignal commit (as it was done for the domain helpers). Reported-by: Raphael Ning Reviewed-by: Juergen Gross --- diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 9ffd2ac66d..cf7297a96c 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1752,7 +1752,7 @@ static bool socket_can_process(struct connection *conn, int mask) return false; } - return (fds[conn->pollfd_idx].revents & mask) && !conn->is_ignored; + return (fds[conn->pollfd_idx].revents & mask); } static bool socket_can_write(struct connection *conn)