From: Phil Elwell Date: Wed, 24 Jan 2018 15:19:39 +0000 (+0000) Subject: lan78xx: Avoid spurious kevent 4 "error" X-Git-Tag: archive/raspbian/4.9.82-1+deb9u3+rpi1_jessie~5^2~35 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=e4540f50fdc570077c446c9612489886494bbc55;p=linux-4.9.git lan78xx: Avoid spurious kevent 4 "error" lan78xx_defer_event generates an error message whenever the work item is already scheduled. lan78xx_open defers three events - EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware of the likelihood (or certainty) of an error message, the DEV_OPEN event is added to the set of pending events directly, relying on the subsequent deferral of the EVENT_LINK_RESET call to schedule the work. Take the same precaution with EVENT_STAT_UPDATE to avoid a totally unnecessary error message. Signed-off-by: Phil Elwell --- diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 13238cb527ca..6bc78a1d1504 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2317,7 +2317,7 @@ static void lan78xx_init_stats(struct lan78xx_net *dev) dev->stats.rollover_max.eee_tx_lpi_transitions = 0xFFFFFFFF; dev->stats.rollover_max.eee_tx_lpi_time = 0xFFFFFFFF; - lan78xx_defer_kevent(dev, EVENT_STAT_UPDATE); + set_bit(EVENT_STAT_UPDATE, &dev->flags); } static int lan78xx_open(struct net_device *net)