From: Kelley Nielsen Date: Mon, 11 Nov 2013 10:08:57 +0000 (-0800) Subject: libxl: add convenience macros to qmp_send() in libxl_qmp.c X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~6039 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=e273738ef1df2e376921ef59c236662d72d0cafa;p=xen.git libxl: add convenience macros to qmp_send() in libxl_qmp.c Update qmp_send() in libxl_qmp.c to use the new convenience macros declared in libxl_internal.h. Uses GC_INIT at the top of the function, and GC_FREE at the exit. Since GC_INIT returns a libxl__gc by reference and not by value, remove the address operator from the left of the variable gc where it is passed as a parameter. Suggested-by: Anthony PERARD Signed-off-by: Kelley Nielsen Acked-by: Ian Campbell --- diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 1f76d53eb0..7fa8748433 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qmp.c @@ -561,9 +561,9 @@ static int qmp_send(libxl__qmp_handler *qmp, { char *buf = NULL; int rc = -1; - libxl__gc gc; LIBXL_INIT_GC(gc,qmp->ctx); + GC_INIT(qmp->ctx); - buf = qmp_send_prepare(&gc, qmp, cmd, args, callback, opaque, context); + buf = qmp_send_prepare(gc, qmp, cmd, args, callback, opaque, context); if (buf == NULL) { goto out; @@ -578,7 +578,7 @@ static int qmp_send(libxl__qmp_handler *qmp, rc = qmp->last_id_used; out: - libxl__free_all(&gc); + GC_FREE; return rc; }