From: Jan Beulich Date: Mon, 18 Sep 2017 10:31:02 +0000 (+0200) Subject: x86emul: re-order checks in test harness X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~1394 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=e25fc4cba8439c068a05f29531811cba71069837;p=xen.git x86emul: re-order checks in test harness On older systems printing the "n/a" messages (resulting from the compiler not being new enough to deal with some of the test code) isn't very useful: If both CPU and compiler are too old for a certain test, we can as well omit those messages, as those tests wouldn't be run even if the compiler did produce code. (This has become obvious with the 3DNow! tests, which I had to run on an older system still supporting those insns, and that system naturally also had an older compiler.) Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- diff --git a/tools/tests/x86_emulator/test_x86_emulator.c b/tools/tests/x86_emulator/test_x86_emulator.c index 76665abda5..4371e467e6 100644 --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -3019,15 +3019,15 @@ int main(int argc, char **argv) for ( j = 0; j < ARRAY_SIZE(blobs); j++ ) { + if ( blobs[j].check_cpu && !blobs[j].check_cpu() ) + continue; + if ( !blobs[j].size ) { printf("%-39s n/a\n", blobs[j].name); continue; } - if ( blobs[j].check_cpu && !blobs[j].check_cpu() ) - continue; - memcpy(res, blobs[j].code, blobs[j].size); ctxt.lma = blobs[j].bitness == 64; ctxt.addr_size = ctxt.sp_size = blobs[j].bitness;