From: Christian Kamm Date: Tue, 11 Aug 2015 08:44:27 +0000 (+0200) Subject: Progress: Robust against bad 'completed' values #3579 X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~1408^2~264 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=e0cf5c3920a890bdc3ff67d6a505693ba8a61cbb;p=nextcloud-desktop.git Progress: Robust against bad 'completed' values #3579 Increasing the 'total' for bogus values of 'completed' is a bad idea. --- diff --git a/src/libsync/progressdispatcher.cpp b/src/libsync/progressdispatcher.cpp index 9627ff314..b39b87c43 100644 --- a/src/libsync/progressdispatcher.cpp +++ b/src/libsync/progressdispatcher.cpp @@ -316,9 +316,8 @@ void ProgressInfo::Progress::update() void ProgressInfo::Progress::setCompleted(quint64 completed) { - _completed = completed; - _prevCompleted = qMin(_prevCompleted, completed); - _total = qMax(_total, completed); + _completed = qMin(completed, _total); + _prevCompleted = qMin(_prevCompleted, _completed); }