From: Luke Yang <luke.jia.yang@gmail.com>
Date: Wed, 12 Jun 2024 19:50:54 +0000 (-0400)
Subject: tree: Fix `name` memory leak
X-Git-Tag: archive/raspbian/2024.8-1+rpi1^2~7^2~1^2~5^2~3
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=dc9eaef1e5143a0276d3fa144b7f295f4f01274a;p=ostree.git

tree: Fix `name` memory leak

Coverity points out that we have a memory leak from `g_strdup(name)`.
`insert_child_mtree()` takes a const char * and duplicates it.
`name` can be passed directly to `insert_child_mtree()`.
---

diff --git a/src/libostree/ostree-mutable-tree.c b/src/libostree/ostree-mutable-tree.c
index 3a47de61..29f72a90 100644
--- a/src/libostree/ostree-mutable-tree.c
+++ b/src/libostree/ostree-mutable-tree.c
@@ -452,7 +452,7 @@ ostree_mutable_tree_ensure_parent_dirs (OstreeMutableTree *self, GPtrArray *spli
           invalidate_contents_checksum (subdir);
           next = ostree_mutable_tree_new ();
           ostree_mutable_tree_set_metadata_checksum (next, metadata_checksum);
-          insert_child_mtree (subdir, g_strdup (name), next);
+          insert_child_mtree (subdir, name, next);
         }
 
       subdir = next;