From: Juergen Gross Date: Wed, 25 Aug 2021 13:11:24 +0000 (+0200) Subject: xen/sched: fix get_cpu_idle_time() for smt=0 suspend/resume X-Git-Tag: archive/raspbian/4.14.3-1+rpi1^2~44^2~8 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=da7254738899da02049dce79bde5af8c27df2481;p=xen.git xen/sched: fix get_cpu_idle_time() for smt=0 suspend/resume With smt=0 during a suspend/resume cycle of the machine the threads which have been parked before will briefly come up again. This can result in problems e.g. with cpufreq driver being active as this will call into get_cpu_idle_time() for a cpu without initialized scheduler data. Fix that by letting get_cpu_idle_time() deal with this case. Drop a redundant check in exchange. Fixes: 132cbe8f35632fb2 ("sched: fix get_cpu_idle_time() with core scheduling") Reported-by: Marek Marczykowski-Górecki Signed-off-by: Juergen Gross Tested-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich Acked-by: Dario Faggioli master commit: 5293470a77ad980dce2af9b7e6c3f11eeebf1b64 master date: 2021-08-19 13:38:31 +0200 --- diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 1bd63c9de6..229ed85f48 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -337,7 +337,7 @@ uint64_t get_cpu_idle_time(unsigned int cpu) struct vcpu_runstate_info state = { 0 }; const struct vcpu *v = idle_vcpu[cpu]; - if ( cpu_online(cpu) && v ) + if ( cpu_online(cpu) && get_sched_res(cpu) ) vcpu_runstate_get(v, &state); return state.time[RUNSTATE_running];