From: Wei Liu <wei.liu2@citrix.com>
Date: Wed, 9 Aug 2017 12:35:19 +0000 (+0100)
Subject: x86/psr: remove useless check in free_socket_resources
X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~1704
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=d73168728c49a21da88989e548f01c5947a5b538;p=xen.git

x86/psr: remove useless check in free_socket_resources

The check is useless because pointer arithmetic ensures "info" is
always non-zero.

Replace it with an ASSERT for socket_info. The only caller of
free_socket_resources already ensures socket_info is not NULL before
calling it.

Coverity-ID: 1416344

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---

diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 9ce8f17a18..84f213ccf6 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -195,8 +195,7 @@ static void free_socket_resources(unsigned int socket)
     unsigned int i;
     struct psr_socket_info *info = socket_info + socket;
 
-    if ( !info )
-        return;
+    ASSERT(socket_info);
 
     /*
      * Free resources of features. The global feature object, e.g. feat_l3,