From: Matthew Daley Date: Wed, 30 Oct 2013 07:51:47 +0000 (+1300) Subject: libxc: remove null pointer checks in xc_pm_get_{c, p}xstat X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~6103 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=d6dea2f6ab0f3724bd6c23d7004913aef2fd8cf2;p=xen.git libxc: remove null pointer checks in xc_pm_get_{c, p}xstat We don't check for null pointers in similar functions, and it's silly to do so for these arguments here anyway; they should fail noisily if null is passed. While at it, remove pointless brackets. Coverity-ID: 1055938 Coverity-ID: 1055939 Signed-off-by: Matthew Daley Reviewed-by: Andrew Cooper Acked-by: Ian Campbell --- diff --git a/tools/libxc/xc_pm.c b/tools/libxc/xc_pm.c index ea1e251fb0..0da2d89934 100644 --- a/tools/libxc/xc_pm.c +++ b/tools/libxc/xc_pm.c @@ -51,7 +51,7 @@ int xc_pm_get_pxstat(xc_interface *xch, int cpuid, struct xc_px_stat *pxpt) int max_px, ret; - if ( !pxpt || !(pxpt->trans_pt) || !(pxpt->pt) ) + if ( !pxpt->trans_pt || !pxpt->pt ) return -EINVAL; if ( (ret = xc_pm_get_max_px(xch, cpuid, &max_px)) != 0) @@ -128,7 +128,7 @@ int xc_pm_get_cxstat(xc_interface *xch, int cpuid, struct xc_cx_stat *cxpt) DECLARE_NAMED_HYPERCALL_BOUNCE(residencies, cxpt->residencies, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); int max_cx, ret; - if( !cxpt || !(cxpt->triggers) || !(cxpt->residencies) ) + if( !cxpt->triggers || !cxpt->residencies ) return -EINVAL; if ( (ret = xc_pm_get_max_cx(xch, cpuid, &max_cx)) )