From: Andrew Cooper Date: Fri, 2 Feb 2018 11:42:05 +0000 (+0000) Subject: x86/emul: Misc non-functional improvements X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~629 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=d28953581b925a2acd7a4eb40b0ca5c7be2d7a5f;p=xen.git x86/emul: Misc non-functional improvements * Drop trailing whitespace * Use ARRAY_SIZE() rather than opencoding it Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index f22f821bc5..bc8fa1d1b1 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1,21 +1,21 @@ /****************************************************************************** * x86_emulate.c - * + * * Generic x86 (32-bit and 64-bit) instruction decoder and emulator. - * + * * Copyright (c) 2005-2007 Keir Fraser * Copyright (c) 2005-2007 XenSource Inc. - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. - * + * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * + * * You should have received a copy of the GNU General Public License * along with this program; If not, see . */ @@ -2650,8 +2650,7 @@ x86_decode( goto done; } } - else if ( ext < ext_8f08 + - sizeof(xop_table) / sizeof(*xop_table) ) + else if ( ext < ext_8f08 + ARRAY_SIZE(xop_table) ) { b = insn_fetch_type(uint8_t); opcode |= MASK_INSR(0x8f08 + ext - ext_8f08, diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index ab5ef4198c..99a618952d 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -1,21 +1,21 @@ /****************************************************************************** * x86_emulate.h - * + * * Generic x86 (32-bit and 64-bit) instruction decoder and emulator. - * + * * Copyright (c) 2005-2007 Keir Fraser * Copyright (c) 2005-2007 XenSource Inc. - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. - * + * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * + * * You should have received a copy of the GNU General Public License * along with this program; If not, see . */ @@ -180,7 +180,7 @@ struct x86_emulate_state; /* * These operations represent the instruction emulator's interface to memory, * I/O ports, privileged state... pretty much everything other than GPRs. - * + * * NOTES: * 1. If the access fails (cannot emulate, or a standard access faults) then * it is up to the memop to propagate the fault to the guest VM via