From: Gao Feng Date: Tue, 31 Oct 2017 10:25:37 +0000 (+0800) Subject: ppp: Destroy the mutex when cleanup X-Git-Tag: archive/raspbian/4.9.80-2+rpi1~7^2~614 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=cf16dac8bd9868cf22203ac498e8e997ad7b0ca1;p=linux-4.9.git ppp: Destroy the mutex when cleanup [ Upstream commit f02b2320b27c16b644691267ee3b5c110846f49e ] The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the good readbility, it's better to invoke it in exit func when the init func invokes mutex_init. Signed-off-by: Gao Feng Acked-by: Guillaume Nault Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index 440d5f42810f..b883af93929c 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -958,6 +958,7 @@ static __net_exit void ppp_exit_net(struct net *net) unregister_netdevice_many(&list); rtnl_unlock(); + mutex_destroy(&pn->all_ppp_mutex); idr_destroy(&pn->units_idr); }