From: Alexander Gerasiov <a@gerasiov.net>
Date: Tue, 23 Sep 2025 10:50:43 +0000 (+0300)
Subject: [PATCH] lib-sieve/sieve-script.c: sieve_script_create_common: Correctly handle errors.
X-Git-Tag: archive/raspbian/1%2.4.1+dfsg1-6+rpi1+deb13u2^2~1
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=cdca3640aee143fcedd030e40c5b7951c28153a5;p=dovecot.git

[PATCH] lib-sieve/sieve-script.c: sieve_script_create_common: Correctly handle errors.

Fixes null pointer deref (e.g. in case of absent file).

Gbp-Pq: Name lib-sieve_sieve-script_c_sieve_script_create_common_Correctly_handle_errors.patch
---

diff --git a/pigeonhole/src/lib-sieve/sieve-script.c b/pigeonhole/src/lib-sieve/sieve-script.c
index 67526c4..caf3c8a 100644
--- a/pigeonhole/src/lib-sieve/sieve-script.c
+++ b/pigeonhole/src/lib-sieve/sieve-script.c
@@ -166,8 +166,8 @@ sieve_script_create_common(struct sieve_instance *svinst,
 		sieve_storage_unref(&storage);
 		if (ret > 0 && open &&
 		    sieve_script_open(script, error_code_r) < 0) {
-			*error_r = sieve_storage_get_last_error(
-				storage, error_code_r);
+			*error_r = sieve_script_get_last_error(
+				script, error_code_r);
 			sieve_script_unref(&script);
 			if (*error_code_r == SIEVE_ERROR_NOT_FOUND)
 				continue;