From: Ian Campbell Date: Fri, 17 Jul 2015 13:21:45 +0000 (+0100) Subject: xen: arm: gic-v3: avoid \n in the middle of log messages X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~2745 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=cd707bceb84febe628dd8f04a33dca6690fec2f6;p=xen.git xen: arm: gic-v3: avoid \n in the middle of log messages These result in log messages such as: (XEN) d0v0: vGICD: RAZ on reserved register offset 0x00000c (XEN) d0v0: vGICR: write r2 offset 0x000180 (XEN) not found<3>traps.c:2417:d0v0 HSR=0x93820046 pc=0xffffffc000322bfc gva=0xffffff8000090180 gpa=0x0000008d110180 Fix this by rewording without a \n in the middle. Also add one at the end. Signed-off-by: Ian Campbell Reviewed-by: Julien Grall --- diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 683e3cc200..f1c482da04 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -193,7 +193,7 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, goto read_as_zero_32; default: printk(XENLOG_G_ERR - "%pv: vGICR: read r%d offset %#08x\n not found", + "%pv: vGICR: unhandled read r%d offset %#08x\n", v, dabt.reg, gicr_reg); return 0; } @@ -269,7 +269,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info, /* RO */ goto write_ignore_32; default: - printk(XENLOG_G_ERR "%pv: vGICR: write r%d offset %#08x\n not found", + printk(XENLOG_G_ERR "%pv: vGICR: unhandled write r%d offset %#08x\n", v, dabt.reg, gicr_reg); return 0; } @@ -515,7 +515,7 @@ static int vgic_v3_rdistr_sgi_mmio_read(struct vcpu *v, mmio_info_t *info, default: printk(XENLOG_G_ERR - "%pv: vGICR: SGI: read r%d offset %#08x\n not found", + "%pv: vGICR: SGI: unhandled read r%d offset %#08x\n", v, dabt.reg, gicr_reg); return 0; } @@ -576,7 +576,7 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info, goto write_ignore_32; default: printk(XENLOG_G_ERR - "%pv: vGICR: SGI: write r%d offset %#08x\n not found", + "%pv: vGICR: SGI: unhandled write r%d offset %#08x\n", v, dabt.reg, gicr_reg); return 0; }