From: Peter Lebbing Date: Thu, 28 Sep 2017 12:40:24 +0000 (+0200) Subject: Bug#877074: u-boot-exynos: Default environment for Odroid XU3 has wrong console var X-Git-Tag: archive/raspbian/2020.07+dfsg-2+rpi1^2^2^2^2^2^2^2^2^2^2^2^2^2^2^2^2^2^2^2^2~5 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=cd549eeda4100873a76bebcaed7fafcec026e5cb;p=u-boot.git Bug#877074: u-boot-exynos: Default environment for Odroid XU3 has wrong console var Package: u-boot-exynos Version: 2017.09+dfsg1-1 Severity: normal Tags: patch The odroid-xu3 platform passes a wrong "console" argument on the kernel commandline: console=console=ttySAC2,115200n8 >From the source, it's clear where this comes from: include/configs/odroid_xu3.h: #define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" #define CONFIG_EXTRA_ENV_SETTINGS \ [...] "console=" CONFIG_DEFAULT_CONSOLE \ /etc/flash-kernel/bootscript/bootscr.uboot-generic: setenv bootargs "${bootargs} console=${console}" The patch below makes the situation equal to what Debian patches in odroid.h: drop it from CONFIG_DEFAULT_CONSOLE. Judging from a grep in include/configs, I think the same situation exists for s5pc210_universal.h, s5p_goni.h, trats2.h and trats.h, but I don't have these devices. There are many more header files that have a "console=" in their CONFIG_DEFAULT_CONSOLE, but I don't see that definition being subsequently used somewhere, so I don't know whether it's being used wrongly or not. Thanks for your efforts, Peter. *** src/debian/u-boot-2017.09+dfsg1/debian/patches/odroid-xu3/double-console-string Gbp-Pq: Topic odroid-xu3 Gbp-Pq: Name 877074-u-boot-exynos-Default-environment-for-Odr.patch --- diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index 899dd1ebf..d03b6107c 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -34,7 +34,7 @@ #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR - 0x1000000) -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" +#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8\0" /* USB */ #define CONFIG_USB_EHCI_EXYNOS