From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Tue, 27 Jun 2017 17:29:55 +0000 (+0100)
Subject: xen/pt: Unlock d->event_lock on error paths
X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~1897
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=ca49c64543864d55c114246f48b28d680c821909;p=xen.git

xen/pt: Unlock d->event_lock on error paths

Introduced by c/s fba00494268 "x86/pt: enable binding of GSIs to a PVH Dom0"

Spotted by Coverity.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
---

diff --git a/xen/drivers/passthrough/io.c b/xen/drivers/passthrough/io.c
index 2fdbba6eb1..25e3fb4078 100644
--- a/xen/drivers/passthrough/io.c
+++ b/xen/drivers/passthrough/io.c
@@ -490,7 +490,11 @@ int pt_irq_create_bind(
             /* MSI_TRANSLATE is not supported for the hardware domain. */
             if ( pt_irq_bind->irq_type != PT_IRQ_TYPE_PCI ||
                  pirq >= hvm_domain_irq(d)->nr_gsis )
+            {
+                spin_unlock(&d->event_lock);
+
                 return -EINVAL;
+            }
             guest_gsi = pirq;
         }
 
@@ -523,6 +527,8 @@ int pt_irq_create_bind(
 
                     if ( mask < 0 || trigger_mode < 0 )
                     {
+                        spin_unlock(&d->event_lock);
+
                         ASSERT_UNREACHABLE();
                         return -EINVAL;
                     }