From: Juergen Gross Date: Fri, 27 Mar 2020 10:44:09 +0000 (+0100) Subject: softirq: adjust comment placement X-Git-Tag: archive/raspbian/4.14.0+80-gd101b417b7-1+rpi1^2~63^2~486 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=c72154e88c6c177ce9b9ec3c5388b5bfcce42f34;p=xen.git softirq: adjust comment placement With commit cef21210fb133 ("rcu: don't process callbacks when holding a rcu_read_lock()") the comment in process_pending_softirqs() about not entering the scheduler should have been moved. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- diff --git a/xen/common/softirq.c b/xen/common/softirq.c index eba65c5fc0..063e93cbe3 100644 --- a/xen/common/softirq.c +++ b/xen/common/softirq.c @@ -56,6 +56,7 @@ static void __do_softirq(unsigned long ignore_mask) void process_pending_softirqs(void) { + /* Do not enter scheduler as it can preempt the calling context. */ unsigned long ignore_mask = (1ul << SCHEDULE_SOFTIRQ) | (1ul << SCHED_SLAVE_SOFTIRQ); @@ -64,7 +65,6 @@ void process_pending_softirqs(void) ignore_mask |= 1ul << RCU_SOFTIRQ; ASSERT(!in_irq() && local_irq_is_enabled()); - /* Do not enter scheduler as it can preempt the calling context. */ __do_softirq(ignore_mask); }