From: Joanmarie Diggs <jdiggs@igalia.com>
Date: Wed, 25 Mar 2015 03:00:20 +0000 (+0100)
Subject: a11y: Free the cell text after emitting text-changed:delete.
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~24^2~9983
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=c66d1656767ce9c4495610fc917a947e7dedbb4e;p=gtk4.git

a11y: Free the cell text after emitting text-changed:delete.

This is needed because AT-SPI2's ATK bridge exposes the deleted string
to ATs.

https://bugzilla.gnome.org/show_bug.cgi?id=746706
---

diff --git a/gtk/a11y/gtktextcellaccessible.c b/gtk/a11y/gtktextcellaccessible.c
index 8ea2d277cf..30a2121f85 100644
--- a/gtk/a11y/gtktextcellaccessible.c
+++ b/gtk/a11y/gtktextcellaccessible.c
@@ -136,7 +136,7 @@ gtk_text_cell_accessible_update_cache (GtkCellAccessible *cell)
 {
   GtkTextCellAccessible *text_cell = GTK_TEXT_CELL_ACCESSIBLE (cell);
   AtkObject *obj = ATK_OBJECT (cell);
-  gint temp_length, text_length;
+  gint text_length;
   gchar *text;
   GtkCellRenderer *renderer;
 
@@ -156,15 +156,13 @@ gtk_text_cell_accessible_update_cache (GtkCellAccessible *cell)
     {
       if (text_cell->priv->cell_length)
         {
-          g_free (text_cell->priv->cell_text);
-          temp_length = text_cell->priv->cell_length;
-          text_cell->priv->cell_text = NULL;
-          text_cell->priv->cell_length = 0;
-          g_signal_emit_by_name (cell, "text-changed::delete", 0, temp_length);
+          g_signal_emit_by_name (cell, "text-changed::delete",
+                                 0, text_cell->priv->cell_length);
           if (obj->name == NULL)
             g_object_notify (G_OBJECT (obj), "accessible-name");
         }
 
+      g_free (text_cell->priv->cell_text);
       text_cell->priv->cell_text = g_strdup (text);
       text_cell->priv->cell_length = text_length;