From: Ian Campbell <ian.campbell@citrix.com>
Date: Mon, 28 Nov 2011 17:42:40 +0000 (+0000)
Subject: libxl: propagate error from tap_ctl_spawn.
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=c5950569ef0a7891d2f5e4a28630f42205f7f344;p=xen.git

libxl: propagate error from tap_ctl_spawn.

Failure here means that a disk will not be correctly setup. I briefly
scanned tools/blktap2/control.c for other goto constructs which did not
set their err variable but didn't see any others.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
---

diff --git a/tools/blktap2/control/tap-ctl-create.c b/tools/blktap2/control/tap-ctl-create.c
index 46d135e93c..f4c47f1f7d 100644
--- a/tools/blktap2/control/tap-ctl-create.c
+++ b/tools/blktap2/control/tap-ctl-create.c
@@ -44,8 +44,10 @@ tap_ctl_create(const char *params, char **devname)
 		return err;
 
 	id = tap_ctl_spawn();
-	if (id < 0)
+	if (id < 0) {
+		err = id;
 		goto destroy;
+	}
 
 	err = tap_ctl_attach(id, minor);
 	if (err)