From: Markus Valentin <markus.valentin@open-xchange.com>
Date: Thu, 23 Apr 2026 10:53:07 +0000 (+0200)
Subject: [PATCH 1/2] submission: Fix settings leak on error paths in client_create_from_input()
X-Git-Tag: archive/raspbian/1%2.4.1+dfsg1-6+rpi1+deb13u7^2~7
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=c20ad113c7f1e6c51deb12227e8437a7c778dc8b;p=dovecot.git

[PATCH 1/2] submission: Fix settings leak on error paths in client_create_from_input()


Gbp-Pq: Name 0001-submission-Fix-settings-leak-on-error-paths-in-clien.patch
---

diff --git a/src/submission/main.c b/src/submission/main.c
index 00e6642..3b110f4 100644
--- a/src/submission/main.c
+++ b/src/submission/main.c
@@ -208,6 +208,7 @@ client_create_from_input(const struct mail_storage_service_input *input,
 			"(submission_relay_host is unset)";
 		send_error(fd_out, event, set->hostname,
 			   "4.3.5", MAIL_ERRSTR_CRITICAL_MSG);
+		settings_free(set);
 		mail_user_deinit(&mail_user);
 		event_unref(&event);
 		return -1;
@@ -216,6 +217,7 @@ client_create_from_input(const struct mail_storage_service_input *input,
 	if (ret < 0) {
 		send_error(fd_out, event, my_hostname,
 			"4.7.0", MAIL_ERRSTR_CRITICAL_MSG);
+		settings_free(set);
 		mail_user_deinit(&mail_user);
 		event_unref(&event);
 		return -1;