From: Matthias Clasen <mclasen@redhat.com>
Date: Fri, 8 Feb 2019 14:49:54 +0000 (-0500)
Subject: assistant: Fix a refcounting oversight
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1^2~18^2~21^2~752
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=c16a861f6811ef3c2013101694f80107422912d1;p=gtk4.git

assistant: Fix a refcounting oversight

The assistant needs to hold a ref on the pages.
---

diff --git a/gtk/gtkassistant.c b/gtk/gtkassistant.c
index 12c38ea43f..f20bbe0428 100644
--- a/gtk/gtkassistant.c
+++ b/gtk/gtkassistant.c
@@ -1773,6 +1773,8 @@ gtk_assistant_insert_page (GtkAssistant *assistant,
   page_info->has_padding = TRUE;
 
   return gtk_assistant_add_page (assistant, page_info, position);
+
+  g_object_unref (page_info);
 }
 
 static int
@@ -1815,7 +1817,7 @@ gtk_assistant_add_page (GtkAssistant *assistant,
   if (position < 0 || position > n_pages)
     position = n_pages;
 
-  priv->pages = g_list_insert (priv->pages, page_info, position);
+  priv->pages = g_list_insert (priv->pages, g_object_ref (page_info), position);
 
   if (position == 0)
     sibling = NULL;