From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Wed, 27 Apr 2016 12:58:27 +0000 (+0100)
Subject: tools/kdd: Fix uninitialised variable warning
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~1218
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=bec4135fdca2538263abb1b552ec2c69539b04c2;p=xen.git

tools/kdd: Fix uninitialised variable warning

Clang warns:

  kdd.c:1031:9: error: variable 'fd' is used uninitialized whenever '||'
  condition is true [-Werror,-Wsometimes-uninitialized]
      if (argc != 4
          ^~~~~~~~~
  kdd.c:1040:20: note: uninitialized use occurs here
      if (select(fd + 1, &fds, NULL, NULL, NULL) > 0)
                 ^~

This situation can't actually happen, as usage() is a terminal path.  Annotate
it appropriately.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
---

diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/kdd/kdd.c
index 9a0225b807..70f007eb17 100644
--- a/tools/debugger/kdd/kdd.c
+++ b/tools/debugger/kdd/kdd.c
@@ -998,7 +998,7 @@ void kdd_select_callback(kdd_state *s)
 }
 
 
-static void usage(void)
+static void __attribute__((noreturn)) usage(void)
 {
     fprintf(stderr, 
 " usage: kdd [-v] <domid> <address> <port>\n"