From: Tim Deegan <tim@xen.org>
Date: Thu, 12 Sep 2013 11:58:11 +0000 (+0100)
Subject: ehci-dbgp: drop dead code.
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~6375
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=bc230d5dcabf31c6db82916df7d0b98ca11fbaad;p=xen.git

ehci-dbgp: drop dead code.

We can only reach this spot by breaking out of the scan loop,
so by construction ret > 0.

Coverity CID 1055259

Signed-off-by: Tim Deegan <tim@xen.org>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---

diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index 25049796e2..301eedf22e 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -946,11 +946,6 @@ try_again:
         dbgp_printk("could not find attached debug device\n");
         goto err;
     }
-    if ( ret < 0 )
-    {
-        dbgp_printk("attached device is not a debug device\n");
-        goto err;
-    }
     dbgp->out.endpoint = dbgp_desc.bDebugOutEndpoint;
     dbgp->in.endpoint = dbgp_desc.bDebugInEndpoint;