From: Alexander Larsson <alexl@redhat.com>
Date: Tue, 8 Sep 2020 09:37:33 +0000 (+0200)
Subject: Fix leak when signing
X-Git-Tag: archive/raspbian/2022.1-3+rpi1~1^2~4^2~7^2~18^2~12
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=bb2649a8c087105542edccbead26b6d9b8fc366a;p=ostree.git

Fix leak when signing

_ostree_detached_metadata_append_gpg_sig() was returning a floating
ref, but all users were using g_autoptr. Fix it by adding a ref-sink.
---

diff --git a/src/libostree/ostree-core.c b/src/libostree/ostree-core.c
index 523f57c0..29528fa5 100644
--- a/src/libostree/ostree-core.c
+++ b/src/libostree/ostree-core.c
@@ -2675,7 +2675,7 @@ _ostree_detached_metadata_append_gpg_sig (GVariant   *existing_metadata,
                                _OSTREE_METADATA_GPGSIGS_NAME,
                                g_variant_builder_end (signature_builder));
 
-  return g_variant_dict_end (&metadata_dict);
+  return g_variant_ref_sink (g_variant_dict_end (&metadata_dict));
 }
 #endif /* OSTREE_DISABLE_GPGME */