From: Timm Bäder <mail@baedert.org>
Date: Wed, 16 Feb 2022 09:01:13 +0000 (+0100)
Subject: gtkgstpaintable: Handle a NULL value
X-Git-Tag: archive/raspbian/4.6.5+ds-1+rpi1~1^2~19^2~3^2~95^2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b74d3c22217be905f51445b49425e44cfd5b2f2a;p=gtk4.git

gtkgstpaintable: Handle a NULL value

gst_element_factory_make can return NULL.
---

diff --git a/modules/media/gtkgstpaintable.c b/modules/media/gtkgstpaintable.c
index aae52b03e5..0a4309b9d3 100644
--- a/modules/media/gtkgstpaintable.c
+++ b/modules/media/gtkgstpaintable.c
@@ -115,7 +115,7 @@ gtk_gst_paintable_video_renderer_create_video_sink (GstPlayerVideoRenderer *rend
                                                     GstPlayer              *player)
 {
   GtkGstPaintable *self = GTK_GST_PAINTABLE (renderer);
-  GstElement *sink, *glsinkbin;
+  GstElement *sink;
   GdkGLContext *ctx;
 
   sink = g_object_new (GTK_TYPE_GST_SINK,
@@ -128,7 +128,10 @@ gtk_gst_paintable_video_renderer_create_video_sink (GstPlayerVideoRenderer *rend
 
   if (self->context != NULL && ctx != NULL)
     {
-      glsinkbin = gst_element_factory_make ("glsinkbin", NULL);
+      GstElement *glsinkbin = gst_element_factory_make ("glsinkbin", NULL);
+
+      if (!glsinkbin)
+        return NULL;
 
       g_object_set (glsinkbin, "sink", sink, NULL);
       g_object_unref (ctx);