From: Jan Beulich <jbeulich@suse.com>
Date: Tue, 12 Mar 2019 13:39:13 +0000 (+0100)
Subject: kexec: suppress bogus warning
X-Git-Tag: archive/raspbian/4.14.0+80-gd101b417b7-1+rpi1^2~63^2~2501
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b49225dc9df336405292dc08862b4c7c9d887bd6;p=xen.git

kexec: suppress bogus warning

Till now "crashkernel=1G-16G:1M" causes

(XEN) crashkernel: '' ignored
(XEN) parameter "crashkernel" has invalid value "1G-16G:1M", rc=-22!

Don't emit the "ignored" warning when there's no placement specification
and the tail of the specified option is actually empty.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index c14cbb2b9c..a262cc5a18 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -173,7 +173,7 @@ static int __init parse_crashkernel(const char *str)
             kexec_crash_area_limit = parse_size_and_unit(cur = str + 1, &str);
         else if ( !strncmp(str, ",below=", 7) )
             kexec_crash_area_limit = parse_size_and_unit(cur = str + 7, &str);
-        else
+        else if ( *str )
         {
             printk(XENLOG_WARNING "crashkernel: '%s' ignored\n", str);
             rc = -EINVAL;