From: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed, 24 Nov 2021 00:09:14 +0000 (-0800) Subject: limit variable scope, found by LGTM. X-Git-Tag: archive/raspbian/1.10.0+ds-2+rpi1~1^2~12^2~2^2~43^2~7 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b2957b54db7d208183ab862990c06574a6c088c0;p=gpsbabel.git limit variable scope, found by LGTM. Poor global variable name 'ops'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). --- diff --git a/jeeps/gpsdevice.cc b/jeeps/gpsdevice.cc index 2c9221e3f..5cfd178c0 100644 --- a/jeeps/gpsdevice.cc +++ b/jeeps/gpsdevice.cc @@ -25,7 +25,7 @@ extern gps_device_ops gps_serial_ops; extern gps_device_ops gps_usb_ops; -gps_device_ops* ops = nullptr; +static gps_device_ops* ops = nullptr; int32 GPS_Device_On(const char* port, gpsdevh** fd) {