From: Julien Grall <jgrall@amazon.com>
Date: Wed, 25 May 2022 08:52:38 +0000 (+0100)
Subject: xen/iommu: dt: Check the return value of xsm_deassign_dtdevice()
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~616
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b22db3fcba1a5b4f9e563b58d402f1d5c434209f;p=xen.git

xen/iommu: dt: Check the return value of xsm_deassign_dtdevice()

xsm_deassign_dtdevice() will indicate whether the caller is allowed
to issue the operation. So the return value has to be checked.

Spotted by clang static analyzer.

Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device")
Signed-off-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---

diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c
index 98f2aa0dad..1c32d7b50c 100644
--- a/xen/drivers/passthrough/device_tree.c
+++ b/xen/drivers/passthrough/device_tree.c
@@ -269,6 +269,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d,
             break;
 
         ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev));
+        if ( ret )
+            break;
 
         if ( d == dom_io )
             return -EINVAL;