From: Jeremy Linton Date: Mon, 24 Feb 2020 22:54:03 +0000 (-0600) Subject: [6/6] net: bcmgenet: reduce severity of missing clock warnings X-Git-Tag: archive/raspbian/5.7.6-1+rpi1^2^2^2^2~17 X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b195e376fc36708b01d6d9124ed17f94835f59c7;p=linux.git [6/6] net: bcmgenet: reduce severity of missing clock warnings Origin: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit?id=ae200c26b32b98f48a9eb5cf53396fd15d94a3cb Bug-Debian: https://bugs.debian.org/950578 If one types "failed to get enet clock" or similar into google there are ~370k hits. The vast majority are people debugging problems unrelated to this adapter, or bragging about their rpi's. Further, the DT clock bindings here are optional. Given that its not a fatal situation with common DT based systems, lets reduce the severity so people aren't seeing failure messages in everyday operation. Signed-off-by: Jeremy Linton Reviewed-by: Nicolas Saenz Julienne Acked-by: Florian Fainelli Signed-off-by: David S. Miller Gbp-Pq: Topic features/all/bcmgenet Gbp-Pq: Name 0006-net-bcmgenet-reduce-severity-of-missing-clock-warnin.patch --- diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 0f007b1130b..18a3bf351ce 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3504,7 +3504,7 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->clk = devm_clk_get(&priv->pdev->dev, "enet"); if (IS_ERR(priv->clk)) { - dev_warn(&priv->pdev->dev, "failed to get enet clock\n"); + dev_dbg(&priv->pdev->dev, "failed to get enet clock\n"); priv->clk = NULL; } @@ -3528,13 +3528,13 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->clk_wol = devm_clk_get(&priv->pdev->dev, "enet-wol"); if (IS_ERR(priv->clk_wol)) { - dev_warn(&priv->pdev->dev, "failed to get enet-wol clock\n"); + dev_dbg(&priv->pdev->dev, "failed to get enet-wol clock\n"); priv->clk_wol = NULL; } priv->clk_eee = devm_clk_get(&priv->pdev->dev, "enet-eee"); if (IS_ERR(priv->clk_eee)) { - dev_warn(&priv->pdev->dev, "failed to get enet-eee clock\n"); + dev_dbg(&priv->pdev->dev, "failed to get enet-eee clock\n"); priv->clk_eee = NULL; }