From: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Date: Wed, 8 Sep 2021 10:11:03 +0000 (+0200)
Subject: no oneliner if: a bug waiting to happen
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~18^2~138^2~3
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b0ef5e06354e8a7c9733c2c7d47db257c020ae42;p=nextcloud-desktop.git

no oneliner if: a bug waiting to happen

it is much too easy to get a bug because one could miss the lask of {
and }

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
---

diff --git a/src/libsync/owncloudpropagator.cpp b/src/libsync/owncloudpropagator.cpp
index 29dc5f23f..f13e69fe5 100644
--- a/src/libsync/owncloudpropagator.cpp
+++ b/src/libsync/owncloudpropagator.cpp
@@ -1106,15 +1106,18 @@ qint64 PropagateRootDirectory::committedDiskSpace() const
 
 bool PropagateRootDirectory::scheduleSelfOrChild()
 {
-    if (_state == Finished)
+    if (_state == Finished) {
         return false;
+    }
 
-    if (PropagateDirectory::scheduleSelfOrChild())
+    if (PropagateDirectory::scheduleSelfOrChild()) {
         return true;
+    }
 
     // Important: Finish _subJobs before scheduling any deletes.
-    if (_subJobs._state != Finished)
+    if (_subJobs._state != Finished) {
         return false;
+    }
 
     return _dirDeletionJobs.scheduleSelfOrChild();
 }