From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Wed, 11 Sep 2024 13:55:27 +0000 (+0800)
Subject: Fix notarisation issues for Sparkle in mac-crafter
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~58^2^2~202^2~6
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b0c4f650fe6567b4815dc1f79067ae81d5166290;p=nextcloud-desktop.git

Fix notarisation issues for Sparkle in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---

diff --git a/admin/osx/mac-crafter/Sources/Utils/Codesign.swift b/admin/osx/mac-crafter/Sources/Utils/Codesign.swift
index 027d99c32..61dfe1237 100644
--- a/admin/osx/mac-crafter/Sources/Utils/Codesign.swift
+++ b/admin/osx/mac-crafter/Sources/Utils/Codesign.swift
@@ -74,6 +74,16 @@ func codesignClientAppBundle(
     try recursivelyCodesign(path: "\(clientContentsDir)/PlugIns", identity: codeSignIdentity)
     try recursivelyCodesign(path: "\(clientContentsDir)/Resources", identity: codeSignIdentity)
 
-    print("Code-signing Nextcloud Desktop Client app bundle...")
-    try codesign(identity: codeSignIdentity, path: clientAppDir)
+    // Time to fix notarisation issues.
+    // Multiple components of the app will now have the get-task-allow entitlements.
+    // We need to strip these out manually.
+
+    print("Code-signing Sparkle autoupdater app (without entitlements)...")
+    let sparkleFrameworkPath = "\(clientContentsDir)/Frameworks/Sparkle.framework"
+    try codesign(identity: codeSignIdentity,
+                 path: "\(sparkleFrameworkPath)/Resources/Autoupdate.app/Contents/MacOS/*",
+                 options: "--timestamp --force --verbose=4 --options runtime")
+
+    print("Re-codesigning Sparkle library...")
+    try codesign(identity: codeSignIdentity, path: "\(sparkleFrameworkPath)/Sparkle")
 }