From: Stefano Crocco <stefano.crocco@alice.it>
Date: Thu, 25 Jul 2019 09:37:51 +0000 (+0200)
Subject: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12
X-Git-Tag: archive/raspbian/4%19.08.2-2+rpi1^2~2
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=b033b6b3096dfd5c543459fb0ca80fb80aaa8da4;p=konqueror.git

Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12

When compiling Konqueror on versions of Qt before 5.12, the
WebEnginePartHtmlEmbedder class is needed to embed local contents in pages
generated by...

Summary:
...WebEnginePartKIOHandler (for example, for the man protocol). The
corresponding source file is added to the the list of source files only if the
Qt version is less than 5.12. However, an extra command in CMakeFiles.txt caused
the file not to be added and the compilation to fail.

Test Plan:
compile Konqueror with Qt older than 5.12.0: the compilation now
completes successfully.

Reviewers: dfaure

Reviewed By: dfaure

Differential Revision: https://phabricator.kde.org/D22736

(cherry picked from commit f9bc950d257f8c7bf30feac5ba9c21de32e4e452)

Gbp-Pq: Name upstream_Fix-CMakeLists.txt-to-compile-WebEnginePartHtmlEmbed.patch
---

diff --git a/webenginepart/src/CMakeLists.txt b/webenginepart/src/CMakeLists.txt
index eb97a16..6a51376 100644
--- a/webenginepart/src/CMakeLists.txt
+++ b/webenginepart/src/CMakeLists.txt
@@ -31,7 +31,7 @@ if(NOT Qt5WebEngineWidgets_VERSION VERSION_LESS "5.12.0")
   add_definitions(-DUSE_QWEBENGINE_URL_SCHEME)
   add_definitions(-DDOWNLOADITEM_KNOWS_PAGE)
 else()
-  list(APPEND kwebenginepartlib_LIB_SRCS, webengineparthtmlembedder.cpp)
+  list(APPEND kwebenginepartlib_LIB_SRCS webengineparthtmlembedder.cpp)
 endif()
 
 qt5_wrap_ui(kwebenginepartlib_LIB_SRCS