From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Thu, 18 Jul 2019 15:24:42 +0000 (+0100)
Subject: xen/trace: Implement TRACE_?D() in a more efficient fashon
X-Git-Tag: archive/raspbian/4.14.0+80-gd101b417b7-1+rpi1^2~63^2~1902
X-Git-Url: https://dgit.raspbian.org/?a=commitdiff_plain;h=af4acbc7a5f705417729e413f7678ae090688a1e;p=xen.git

xen/trace: Implement TRACE_?D() in a more efficient fashon

These can easily be expressed with a variadic macro. No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
---

diff --git a/xen/include/xen/trace.h b/xen/include/xen/trace.h
index bd5168f568..af925bcfcc 100644
--- a/xen/include/xen/trace.h
+++ b/xen/include/xen/trace.h
@@ -81,80 +81,33 @@ static inline void __trace_hypercall(uint32_t event, unsigned long op,
     do {                                        \
         trace_var(_e, 1, 0, NULL);              \
     } while ( 0 )
-  
-#define TRACE_1D(_e,d1)                                         \
-    do {                                                        \
-        if ( unlikely(tb_init_done) )                           \
-        {                                                       \
-            u32 _d[1];                                          \
-            _d[0] = d1;                                         \
-            __trace_var(_e, 1, sizeof(_d), _d);                 \
-        }                                                       \
-    } while ( 0 )
- 
-#define TRACE_2D(_e,d1,d2)                                      \
-    do {                                                        \
-        if ( unlikely(tb_init_done) )                           \
-        {                                                       \
-            u32 _d[2];                                          \
-            _d[0] = d1;                                         \
-            _d[1] = d2;                                         \
-            __trace_var(_e, 1, sizeof(_d), _d);                 \
-        }                                                       \
-    } while ( 0 )
- 
-#define TRACE_3D(_e,d1,d2,d3)                                   \
-    do {                                                        \
-        if ( unlikely(tb_init_done) )                           \
-        {                                                       \
-            u32 _d[3];                                          \
-            _d[0] = d1;                                         \
-            _d[1] = d2;                                         \
-            _d[2] = d3;                                         \
-            __trace_var(_e, 1, sizeof(_d), _d);                 \
-        }                                                       \
-    } while ( 0 )
- 
-#define TRACE_4D(_e,d1,d2,d3,d4)                                \
-    do {                                                        \
-        if ( unlikely(tb_init_done) )                           \
-        {                                                       \
-            u32 _d[4];                                          \
-            _d[0] = d1;                                         \
-            _d[1] = d2;                                         \
-            _d[2] = d3;                                         \
-            _d[3] = d4;                                         \
-            __trace_var(_e, 1, sizeof(_d), _d);                 \
-        }                                                       \
-    } while ( 0 )
- 
-#define TRACE_5D(_e,d1,d2,d3,d4,d5)                             \
-    do {                                                        \
-        if ( unlikely(tb_init_done) )                           \
-        {                                                       \
-            u32 _d[5];                                          \
-            _d[0] = d1;                                         \
-            _d[1] = d2;                                         \
-            _d[2] = d3;                                         \
-            _d[3] = d4;                                         \
-            _d[4] = d5;                                         \
-            __trace_var(_e, 1, sizeof(_d), _d);                 \
-        }                                                       \
-    } while ( 0 )
 
-#define TRACE_6D(_e,d1,d2,d3,d4,d5,d6)                             \
-    do {                                                        \
-        if ( unlikely(tb_init_done) )                           \
-        {                                                       \
-            u32 _d[6];                                          \
-            _d[0] = d1;                                         \
-            _d[1] = d2;                                         \
-            _d[2] = d3;                                         \
-            _d[3] = d4;                                         \
-            _d[4] = d5;                                         \
-            _d[5] = d6;                                         \
-            __trace_var(_e, 1, sizeof(_d), _d);                 \
-        }                                                       \
+/* Common helper for TRACE_{1..6}D() below. */
+#define TRACE_varD(_e, ...)                             \
+    do {                                                \
+        if ( unlikely(tb_init_done) )                   \
+        {                                               \
+            uint32_t _d[] = { __VA_ARGS__ };            \
+            __trace_var(_e, true, sizeof(_d), _d);      \
+        }                                               \
     } while ( 0 )
 
+#define TRACE_1D(_e, d1) \
+    TRACE_varD(_e, d1)
+
+#define TRACE_2D(_e, d1, d2) \
+    TRACE_varD(_e, d1, d2)
+
+#define TRACE_3D(_e, d1, d2, d3) \
+    TRACE_varD(_e, d1, d2, d3)
+
+#define TRACE_4D(_e, d1, d2, d3, d4) \
+    TRACE_varD(_e, d1, d2, d3, d4)
+
+#define TRACE_5D(_e, d1, d2, d3, d4, d5) \
+    TRACE_varD(_e, d1, d2, d3, d4, d5)
+
+#define TRACE_6D(_e, d1, d2, d3, d4, d5, d6) \
+    TRACE_varD(_e, d1, d2, d3, d4, d5, d6)
+
 #endif /* __XEN_TRACE_H__ */